Closed Bug 803951 Opened 13 years ago Closed 13 years ago

restore screen brightness when turning the screen back on

Categories

(Firefox OS Graveyard :: Gaia, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: gal, Unassigned)

References

Details

Attachments

(1 file)

Right now when auto brightness is turned on and the screen is turned off and back on, we restore brightness to _userBrightness, which is usually 1. In other words the screen has maximum brightness coming back on. Instead, we should restore the previous brightness value.
Not a blocker. Requesting approval. Small low-risk patch that solves an irritating problem.
Attached patch patch — — Splinter Review
NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): bad original implementation User impact if declined: weird lockscreen light experience Testing completed: yes Risk to taking this patch (and alternatives if risky): very low
Attachment #673685 - Flags: review?(21)
Attachment #673685 - Flags: approval-gaia-master?(21)
Attachment #673685 - Flags: review?(21)
Attachment #673685 - Flags: review+
Attachment #673685 - Flags: approval-gaia-master?(21)
Attachment #673685 - Flags: approval-gaia-master+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Depends on: 804328
This issue fixed for device Ungia; build #20130104070203 v.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: