804328 - Fix setScreenBrightness assertion failure because ScreenManager._savedBrightness is undefined

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Launch B2GDebug.app build
2. On lock screen, press HOME key

RESULT:
PowerManager.cpp asserts because ScreenManager._savedBrightness is undefined:

SetScreenBrightness(nan)
[Parent 7718] WARNING: NS_ENSURE_TRUE(0 <= aBrightness && aBrightness <= 1) failed: file /Users/cpeterson/Code/mozilla/b2g/central/dom/power/PowerManager.cpp, line 157

This is a recent regression from bug 803951.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: fix-setScreenBrightness-assertion.patch

This PowerManager.cpp assertion failure is a regression from bug 803951. ScreenManager._savedBrightness is read before it is defined.


NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 673997 [details] [diff] [review]
fix-setScreenBrightness-assertion.patch

Review of attachment 673997 [details] [diff] [review]:
-----------------------------------------------------------------

I believe this is a kind of followup of Andreas patch.

One liner. a=me.

Comment 3

[Chris Peterson [:cpeterson]]

https://github.com/mozilla-b2g/gaia/pull/5958

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/pull/5958

merged, what are you waiting for?! :)

Comment 5

[Chris Peterson [:cpeterson]]

https://github.com/mozilla-b2g/gaia/commit/1efaf971f24f0b89eff8a37add89420935c46701

Comment 7

[amiller]

Device: Unagi
Build: 20130102070202

Does not reproduce on this device and build. Saved brightness is defined