804292 - [socorro-crashstats] Use middleware to fetch platforms

Status: RESOLVED DUPLICATE of bug 1066344

(Socorro :: Webapp, task, P4)

Description

[Peter Bengtsson [:peterbe]]

At the time of writing the models.Platforms class is hardcoded. It should be fed from the middleware instead.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

PR: https://github.com/mozilla/socorro-crashstats/pull/242

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/bc222d2f7286c0e3f26275151b44e239b798ac16
Fixes bug 804292 - Platforms come from the middleware.

https://github.com/mozilla/socorro-crashstats/commit/08565146c8706ded97732bb52d5a87d6d4f52cf6
Merge pull request #242 from AdrianGaudebert/804292-platforms-model-call-middleware

Fixes bug 804292 - Platforms come from the middleware.

Comment 3

[Robert Helmer [:rhelmer]]

Backed this out because it broke the topcrashers page:

Environment:


Request Method: GET
Request URL: http://localhost:8000/topcrasher/products/Firefox/versions/19.0a1?days=7

Django Version: 1.4.2
Python Version: 2.7.3
Installed Applications:
['funfactory',
 'compressor',
 'tower',
 'cronjobs',
 'django_browserid',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.staticfiles',
 'commonware.response.cookies',
 'djcelery',
 'django_nose',
 'session_csrf',
 'product_details',
 'crashstats.base',
 'crashstats.crashstats',
 'jingo_offline_compressor',
 'crashstats.auth',
 'django_statsd',
 'django.contrib.messages']
Installed Middleware:
('multidb.middleware.PinningRouterMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'session_csrf.CsrfMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'commonware.middleware.FrameOptionsHeader',
 'mobility.middleware.DetectMobileMiddleware',
 'mobility.middleware.XMobileMiddleware',
 'django_statsd.middleware.GraphiteRequestTimingMiddleware',
 'django_statsd.middleware.GraphiteMiddleware')


Traceback:
File "/home/rhelmer/src/socorro-crashstats/vendor/lib/python/django/core/handlers/base.py" in get_response
  111.                         response = callback(request, *callback_args, **callback_kwargs)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/views.py" in inner
  155.         return view(request, *args, **kwargs)
File "/home/rhelmer/src/socorro-crashstats/vendor/src/django-session-csrf/session_csrf/__init__.py" in wrapper
  127.         response = f(request, *args, **kw)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/decorators.py" in inner
  35.             return view(request, *args, **kwargs)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/views.py" in topcrasher
  318.             crash_counts.append([crash[key], os['name']])

Exception Type: KeyError at /topcrasher/products/Firefox/versions/19.0a1
Exception Value: u'unk_count'

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/15333bd956fe71f3393b54271a644d84143fec21
Revert "Fixes bug 804292 - Platforms come from the middleware."

This reverts commit bc222d2f7286c0e3f26275151b44e239b798ac16.

https://github.com/mozilla/socorro-crashstats/commit/1eab9b878f869b79fbbbe38045e74f17ada3d9b1
Merge pull request #263 from rhelmer/backout-bug804292

Revert "Fixes bug 804292 - Platforms come from the middleware."

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

This change has impacts on a lot more things than I expected. I'll need to make changes to both the middleware and the UI, so I'll wait until we get rid of the old UI completely.