Closed Bug 804416 Opened 8 years ago Closed 8 years ago

toolbar notification cache used even when social is disabled

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set
normal

Tracking

(firefox17+ fixed, firefox18+ fixed, firefox19 fixed)

RESOLVED FIXED
Firefox 19
Tracking Status
firefox17 + fixed
firefox18 + fixed
firefox19 --- fixed

People

(Reporter: markh, Assigned: markh)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

If there are cached notification icons for a provider, then you disable social and restart, those cached items are still used, even though they are not visible.  This can result in errors in the js console:

Timestamp: 23/10/2012 11:34:42 AM
Error: TypeError: navigator.mozSocial is undefined
Source File: https://s-static.ak.fbcdn.net/rsrc.php/v2/yE/r/e96h7ImncfC.js
Line: 6
OS: Windows 7 → All
Hardware: x86_64 → All
We probably want this in aurora/beta too as it may appear as though the provider is being "pinged" even when disabled.
Assignee: nobody → mhammond
Attachment #674098 - Flags: review?(felipc)
Attachment #674098 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/db2bf849fcb5
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
We need this on aurora/beta, right?
Comment on attachment 674098 [details] [diff] [review]
only use the toolbar cache when provider is active.

[Triage Comment]
a=me
Attachment #674098 - Flags: approval-mozilla-beta+
Attachment #674098 - Flags: approval-mozilla-aurora+
Please remove [qa-] whiteboard tag and add verifyme keyword if there's some QA testing needed here. Otherwise we will skip verification.
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.