804416 - toolbar notification cache used even when social is disabled

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

If there are cached notification icons for a provider, then you disable social and restart, those cached items are still used, even though they are not visible.  This can result in errors in the js console:

Timestamp: 23/10/2012 11:34:42 AM
Error: TypeError: navigator.mozSocial is undefined
Source File: https://s-static.ak.fbcdn.net/rsrc.php/v2/yE/r/e96h7ImncfC.js
Line: 6

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: only use the toolbar cache when provider is active.

We probably want this in aurora/beta too as it may appear as though the provider is being "pinged" even when disabled.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db2bf849fcb5

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db2bf849fcb5

Comment 4

[:Gavin Sharp [email: [e-mail]]]

We need this on aurora/beta, right?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 674098 [details] [diff] [review]
only use the toolbar cache when provider is active.

[Triage Comment]
a=me

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3b3c91fdbbb9
https://hg.mozilla.org/releases/mozilla-beta/rev/dff151391688

Comment 7

[u279076]

Please remove [qa-] whiteboard tag and add verifyme keyword if there's some QA testing needed here. Otherwise we will skip verification.