toolbar notification cache used even when social is disabled

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

unspecified
Firefox 19
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox17+ fixed, firefox18+ fixed, firefox19 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
If there are cached notification icons for a provider, then you disable social and restart, those cached items are still used, even though they are not visible.  This can result in errors in the js console:

Timestamp: 23/10/2012 11:34:42 AM
Error: TypeError: navigator.mozSocial is undefined
Source File: https://s-static.ak.fbcdn.net/rsrc.php/v2/yE/r/e96h7ImncfC.js
Line: 6
(Assignee)

Updated

5 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Comment 1

5 years ago
Created attachment 674098 [details] [diff] [review]
only use the toolbar cache when provider is active.

We probably want this in aurora/beta too as it may appear as though the provider is being "pinged" even when disabled.
Assignee: nobody → mhammond
Attachment #674098 - Flags: review?(felipc)
(Assignee)

Updated

5 years ago
status-firefox17: --- → affected
status-firefox18: --- → affected
status-firefox19: --- → affected
Attachment #674098 - Flags: review?(felipc) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/db2bf849fcb5
https://hg.mozilla.org/mozilla-central/rev/db2bf849fcb5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19

Updated

5 years ago
status-firefox19: affected → ---
We need this on aurora/beta, right?
tracking-firefox17: --- → +
tracking-firefox18: --- → +
Comment on attachment 674098 [details] [diff] [review]
only use the toolbar cache when provider is active.

[Triage Comment]
a=me
Attachment #674098 - Flags: approval-mozilla-beta+
Attachment #674098 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/3b3c91fdbbb9
https://hg.mozilla.org/releases/mozilla-beta/rev/dff151391688
status-firefox17: affected → fixed
status-firefox18: affected → fixed
status-firefox19: --- → fixed
Please remove [qa-] whiteboard tag and add verifyme keyword if there's some QA testing needed here. Otherwise we will skip verification.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.