Closed
Bug 804481
Opened 12 years ago
Closed 12 years ago
Add UA override for accounts.google.com
Categories
(Firefox OS Graveyard :: Gaia, defect, P1)
Tracking
(blocking-basecamp:+)
VERIFIED
FIXED
blocking-basecamp | + |
People
(Reporter: jsmith, Assigned: bjacob)
References
Details
Attachments
(1 file)
782 bytes,
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
accounts.google.com is going to be used basically when you visit any site that requires login via your google account. We should probably consider putting a UA override here, as we currently get the desktop site right now.
Reporter | ||
Comment 1•12 years ago
|
||
Many top sites use accounts.google.com - putting this on the nom to block.
blocking-basecamp: --- → ?
Comment 2•12 years ago
|
||
Is there a corresponding evangelism bug for this site?
Comment 3•12 years ago
|
||
Lawrence, what do you think about a UA override here?
Flags: needinfo?(jsmith)
Reporter | ||
Comment 4•12 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #2)
> Is there a corresponding evangelism bug for this site?
Filed bug 805164.
Flags: needinfo?(jsmith)
Reporter | ||
Updated•12 years ago
|
Flags: needinfo?(lmandel)
Comment 5•12 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #3)
> Lawrence, what do you think about a UA override here?
UA override is applicable for Google accounts for the reason Jason stated above. Joanne Nagel is currently in touch with Google, which has been willing to work with us on compat issues. We should first try evangelism before going to the whitelist.
Blocks: google.com
Flags: needinfo?(lmandel)
Updated•12 years ago
|
blocking-basecamp: ? → +
Whiteboard: [blocked-on-input Lawrence Mandel]
Updated•12 years ago
|
Assignee: nobody → lmandel
Whiteboard: [blocked-on-input Lawrence Mandel]
Comment 6•12 years ago
|
||
Google is investigating the issues that we have on file in Bugzilla. I do not have a timeline on any fix at this point.
Updated•12 years ago
|
Assignee: lmandel → bjacob
Assignee | ||
Comment 7•12 years ago
|
||
I have a question --- exactly the same as I asked in bug 803741 comment 10. Basically, is the patch as simple as
+pref("general.useragent.override.accounts.google.com", "\(Mobile#(Android; Mobile");
?
Assignee | ||
Comment 8•12 years ago
|
||
Attachment #686559 -
Flags: review?(21)
Attachment #686559 -
Flags: review?(21) → review?(poirot.alex)
Comment 9•12 years ago
|
||
Comment on attachment 686559 [details] [diff] [review]
Add UA override for accounts.google.com
Tested, works fine.
You will have to submit a pull request in order to merge this patch.
Attachment #686559 -
Flags: review?(poirot.alex) → review+
Updated•12 years ago
|
Priority: -- → P1
Assignee | ||
Comment 10•12 years ago
|
||
pull request: https://github.com/mozilla-b2g/gaia/pull/6726
erm, this seems to also have the commit from my dailymotion branch. I'm a n00b with git and I don't know if that's going to be a problem.
Comment 11•12 years ago
|
||
No git is smart :)
Landed:
https://github.com/mozilla-b2g/gaia/commit/409c7c0ce1309efcd2d4df38a16e5c62acef8167
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Component: General → Gaia
You need to log in
before you can comment on or make changes to this bug.
Description
•