804529 - Search doesn't work second time after going back in history

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[Martijn Wargers (dead)]

Steps to reproduce:
- Go to http://support.mozilla.org/nl/questions/929653
- Type something in the search bar (e.g. 'test'), press enter
- Wait for the resulting page
- Go back in history
- Type something in the search bar again, try to submit

Expected result:
- Should be able to submit the search input

Actual result:
- Not able to submit a search

This is happening because after going back in history, you get the bfcached page in Firefox. 
And apparently, after a search, the form gets class="disabled" on it, which prevents submitting the form another time (this is done by some js on the page).
But that means the bfcached page in Firefox also still has this class="disabled" on the form.

I guess a solution would be to turn the form back on after 1 second or so, using a timer. That would prevent double submits, but would still allow to search again on a page that was bfcached.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

We can probably do something on page unload.

Comment 2

[James Socol [:jsocol, :james]]

Why does it get class="disabled", anyway? A double-submit on a GET is fine, since the request is idempotent.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

We just have generic code that disables all forms on submit. But yeah, it could ignore forms with method="get". I am pretty sure it's an easy fix by attaching to page unload event anyway.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request: https://github.com/mozilla/kitsune/pull/917

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

I fixed this during 2012.20:
https://github.com/mozilla/kitsune/commit/dc02aebce853cc4793c146c9f9062d495049a3dc

I'll deploy shortly.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod.

Comment 7

[Martijn Wargers (dead)]

Ok, it seems to work now, thanks. The only gripe with using an unload event handler is that it breaks bfcache in Firefox. So going back a page isn't that quick anymore.

Comment 8

[Kadir Topal [:atopal]]

Since this is generic, does this mean that we are submitting another GET request as people are clicking the back button to get to the search results page? And that we were not doing that before? Depending on how often people click back that might have an impact on our KPI.

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Kadir Topal [:atopal] from comment #8)
> Since this is generic, does this mean that we are submitting another GET
> request as people are clicking the back button to get to the search results
> page?

Yes, it will result in a new GET.

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

I am going to change the code so that it only affects submitting forms over POST. That way it doesn't affect search.

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #10)
> I am going to change the code so that it only affects submitting forms over
> POST. That way it doesn't affect search.

landed: https://github.com/mozilla/kitsune/commit/472dfb2bf533fcc1a4c9dfaa307cef9e861e36c6

Will be deployed shortly.

Comment 12

[Kadir Topal [:atopal]]

perfect, thanks!