Closed Bug 804641 Opened 8 years ago Closed 8 years ago

Work around Android armv6 compiler bug (again)

Categories

(Core :: Layout: Block and Inline, defect, major)

ARM
Android
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox17 + fixed
firefox18 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

(Keywords: qawanted)

Attachments

(2 files)

Work around Android armv6 compiler bug 790624.
"Again" because this was apparently worked around once before in
bug 642205 but it seems it's broken slightly differently on armv6.
Attached patch workaroundSplinter Review
This is a (new) workaround for the *compiler bug* in bug 790624.
It fixes the testcase attached in that bug in my local armv6 build.

I've pushed this from my Aurora tree to Try, not sure if that works:
https://tbpl.mozilla.org/?tree=Try&rev=cec60db1e750
Attachment #674274 - Flags: review?(roc)
> I've pushed this from my Aurora tree to Try, not sure if that works

Apparently not.  Here's a mozilla-central Try push instead:
https://tbpl.mozilla.org/?tree=Try&rev=6882a3e70091
Comment on attachment 674274 [details] [diff] [review]
workaround

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: potential layout errors involving scrollable elements
Testing completed (on m-c, etc.): tested in local armv6 Android Firefox
Risk to taking this patch (and alternatives if risky): very low risk, it's just reshuffling the code a bit to avoid a compiler bug, there's no functional change
String or UUID changes made by this patch: none


This bug was spawned from bug 790624 which has tracking-firefox17+.
I don't know if it's needed for beta, please mark it beta- if not.
Attachment #674274 - Flags: approval-mozilla-beta?
Attachment #674274 - Flags: approval-mozilla-aurora?
Silly me, 17 is in beta now... so, yeah, definitely needed there.
https://hg.mozilla.org/mozilla-central/rev/332a8a91de0a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Attachment #674274 - Flags: approval-mozilla-beta?
Attachment #674274 - Flags: approval-mozilla-beta+
Attachment #674274 - Flags: approval-mozilla-aurora?
Attachment #674274 - Flags: approval-mozilla-aurora+
QA: please also check if any of the other tests in bug 791103 was fixed by this.
Keywords: verifyme
Keywords: qawanted
QA Contact: kbrosnan
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.