804641 - Work around Android armv6 compiler bug (again)

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Mats Palmgren (inactive)]

Work around Android armv6 compiler bug 790624.
"Again" because this was apparently worked around once before in
bug 642205 but it seems it's broken slightly differently on armv6.

Comment 1

[Mats Palmgren (inactive)]

Attachment: workaround

This is a (new) workaround for the *compiler bug* in bug 790624.
It fixes the testcase attached in that bug in my local armv6 build.

I've pushed this from my Aurora tree to Try, not sure if that works:
https://tbpl.mozilla.org/?tree=Try&rev=cec60db1e750

Comment 2

[Mats Palmgren (inactive)]

Attachment: wdiff of the same

Comment 3

[Mats Palmgren (inactive)]

> I've pushed this from my Aurora tree to Try, not sure if that works

Apparently not.  Here's a mozilla-central Try push instead:
https://tbpl.mozilla.org/?tree=Try&rev=6882a3e70091

Comment 4

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/332a8a91de0a

Comment 5

[Mats Palmgren (inactive)]

Comment on attachment 674274 [details] [diff] [review]
workaround

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: potential layout errors involving scrollable elements
Testing completed (on m-c, etc.): tested in local armv6 Android Firefox
Risk to taking this patch (and alternatives if risky): very low risk, it's just reshuffling the code a bit to avoid a compiler bug, there's no functional change
String or UUID changes made by this patch: none


This bug was spawned from bug 790624 which has tracking-firefox17+.
I don't know if it's needed for beta, please mark it beta- if not.

Comment 6

[Mats Palmgren (inactive)]

Silly me, 17 is in beta now... so, yeah, definitely needed there.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/332a8a91de0a

Comment 8

[Mats Palmgren (inactive)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ce80f2d6cd43
https://hg.mozilla.org/releases/mozilla-beta/rev/70af899a0e06

Comment 9

[Mats Palmgren (inactive)]

QA: please also check if any of the other tests in bug 791103 was fixed by this.

Comment 10

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old