Closed Bug 826411 Opened 7 years ago Closed 7 years ago

Back out compiler-specific workarounds

Categories

(Core :: Layout, defect)

20 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch (1/2) backout of 332a8a91de0a (obsolete) — Splinter Review
Bug 642205 (cset 9c3ef79b8eba) and bug 804641 (cset 332a8a91de0a) added workarounds for a compiler bug that manifested when compiling for ARMv6 using gcc-4.4.3. As of bug 825453, we have moved from gcc-4.4.3 to gcc-4.6, which doesn't have the problem. Therefore we can back out the workarounds.

Some of the bugs/test failures that were fixed by the workarounds are bug 792300, bug 790624, and bug 790630.

The try run of the backout at https://tbpl.mozilla.org/?tree=Try&rev=486c8343b80a shows that all the ARMv6 tests are still passing just fine.
Attachment #697595 - Flags: review?(matspal)
Attached patch (2/2) backout of 9c3ef79b8eba (obsolete) — Splinter Review
Assignee: nobody → bugmail.mozilla
Attachment #697596 - Flags: review?(matspal)
Comment on attachment 697595 [details] [diff] [review]
(1/2) backout of 332a8a91de0a

I think the code is much clearer as it's currently written.

It's three simple if-statements with early returns in the first two,
and 'result' is only used in the last.  Compare this with 'result'
being visible to all three (used in two) if-statements in the previous
code, and where the 3rd if-statement is nested inside an if-else
and falls through.

Just remove the XXX comment.
Attachment #697595 - Flags: review?(matspal) → review-
Attachment #697596 - Flags: review?(matspal) → review-
Attached patch Remove commentSplinter Review
Fair enough.
Attachment #697595 - Attachment is obsolete: true
Attachment #697596 - Attachment is obsolete: true
Attachment #697799 - Flags: review?(matspal)
Attachment #697799 - Flags: review?(matspal) → review+
Version: 19 Branch → 20 Branch
https://hg.mozilla.org/mozilla-central/rev/8e9d95ecd256
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.