804656 - flyout panel blocking events to sidebar

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Anthony Hughes (:ashughes) [QA]]

When I hover an activity item in the sidebar it displays a flyout, but if I try to mouse-scroll the activity stream with a flyout visible I can't. This makes scrolling the activity stream difficult because I need to make sure I start scrolling within the hover timeout for displaying the flyout.

Comment 2

[Shane Caraveo (:mixedpuppy)]

scroll and click events are consumed by the flyout on osx and linux.  Windows does not seem to be affected by this.  All versions are affected.

Comment 3

[Shane Caraveo (:mixedpuppy)]

click events (on osx) will go through if using consumeoutsideclicks=false on the panel, however this does not fix the scroll event issue.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Neil, do you have any thoughts around the scroll issue here?

Comment 5

[Neil Deakin (away Dec 12 - Dec 20)]

The addition mentioned at http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsXULPopupManager.cpp#215 would need to be implemented. Similar issue as with bug 628020.

Comment 6

[Shane Caraveo (:mixedpuppy)]

actually, consumeoutsideclicks=false causes some very strange behavior in our sidebar, I don't think it is a content issue since this works as expected on windows (without consumeoutsideclicks=false).

Comment 8

[edA-qa mort-ora-y]

Duplicate of this bug: 800816

Comment 10

[Shane Caraveo (:mixedpuppy)]

Attachment: scroll event patch

This patch allows the scroll event to reach the sidebar while the flyout panel is open.  This matches the windows behavior.

Comment 11

[Neil Deakin (away Dec 12 - Dec 20)]

Comment on attachment 689489 [details] [diff] [review]
scroll event patch

It doesn't match the Mac behaviour though. In fact, my testing shows that it isn't correct on Windows either. That is, when a menu is open, the scrollwheel should not be able to scroll the document.

What we actually want is a way to customize either the consume of the scroll event or whether the the rollup occurs (or probably both), as I mentioned in comment 5.

Comment 12

[Shane Caraveo (:mixedpuppy)]

Attachment: rollup on mousewheel

this adds a rolluponmousewheel attribute for panels, and in combination with consumeoutsideclicks I get the behavior I need on the social flyout panel.

Comment 13

[Neil Deakin (away Dec 12 - Dec 20)]

Comment on attachment 692121 [details] [diff] [review]
rollup on mousewheel

This is fine, although someone else just recently asked for the ability to control consume on mousewheel separately from click, so I want to think for a bit about how this might be incorporated as well.

> +  content->GetAttr(kNameSpaceID_None, nsGkAtoms::rolluponmousewheel, rollup);
> +  return rollup.EqualsLiteral("true");

Note that you can use AttrValueIs here.

Comment 14

[Shane Caraveo (:mixedpuppy)]

Neil, I'm going to assign this to you while you think about stuff from your last comment.  Once you figure out how you want it to go, I'll be happy to have it reassigned to me to update/etc.

Comment 15

[Neil Deakin (away Dec 12 - Dec 20)]

I can't find any reference to who asked about the ability to control the 'consume' ability as well, so let's just go with this patch and change it later if someone asks.

- change to use AttrValueIs
- move the check to before the autocomplete popup and allow rolluponmousewheel="false" to override it (like http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsMenuPopupFrame.cpp#1392 does for consumeoutsideclicks)
- put the atom in alphabetical order in nsGkAtomList

Comment 16

[Shane Caraveo (:mixedpuppy)]

Attachment: rollup on mousewheel

Comment 17

[Shane Caraveo (:mixedpuppy)]

https://tbpl.mozilla.org/?tree=Try&rev=04aa7c6726af

Comment 18

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf2bcfc5cb4d

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cf2bcfc5cb4d

Comment 20

[Anthony Hughes (:ashughes) [QA]]

I've not been able to reproduce this recently, marking verified fixed.