Can't use ctrlKey+arrowkey to move to next/previous word or select words, in groupname <input>

RESOLVED WONTFIX

Status

Firefox Graveyard
Panorama
RESOLVED WONTFIX
5 years ago
2 years ago

People

(Reporter: Johan C, Unassigned)

Tracking

18 Branch
x86_64
Windows 7

Details

Attachments

(1 attachment, 2 obsolete attachments)

1.67 KB, patch
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
Created attachment 674345 [details] [diff] [review]
patch v1

In the tabview groupname <input>, you can't use the ctrl modifier to jump to the next/previous word, or select a word.
Attachment #674345 - Flags: review?(ttaubert)
(Reporter)

Comment 1

5 years ago
Created attachment 674359 [details] [diff] [review]
patch v2

Sorry, I did not quite think it through with the first patch. This should work better.
Attachment #674345 - Attachment is obsolete: true
Attachment #674345 - Flags: review?(ttaubert)
Attachment #674359 - Flags: review?(ttaubert)
Comment on attachment 674359 [details] [diff] [review]
patch v2

Review of attachment 674359 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, Johan! We unfortunately can't do it that way. The default action is to block events unless the shortcut is white-listed and contained in this._browserKeys*. We need this to block other shortcuts that shouldn't be reachable while Panorama is active.

There would be Cmd+Left/Right and Alt+Left/Right that we'd need to white list on Mac. On PC it's Ctrl+Home/End/Left/Right/Backspace/Delete (I may have forgotten some combinations). I think that's not too easy to do and would need another white-list approach.
Attachment #674359 - Flags: review?(ttaubert) → review-
(Reporter)

Comment 3

5 years ago
Created attachment 674784 [details] [diff] [review]
patch v3

Here's another patch with the whitelist approach.

I'm not sure if adding "evt.altKey" here could cause any problems, what do you think?
-        if (evt.metaKey) {
+        if (evt.metaKey || evt.altKey) {

/tabview/test/ passed.
Attachment #674359 - Attachment is obsolete: true
Attachment #674784 - Flags: feedback?(ttaubert)
Comment on attachment 674784 [details] [diff] [review]
patch v3

Thanks for the patch, Johan. I don't want to take any more changes before turning Panorama into an add-on so let's wait until that happened.
Attachment #674784 - Flags: feedback?(ttaubert)

Updated

3 years ago
See Also: → bug 1153599
Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

2 years ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.