80473 - No Context menu if page has a background.

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Marc Loiselle]

Context Menus work for pages without a background.

Buildid 2001051206.

JavaScript error:
chrome://communicator/content/nsContextMenu.js line 646: doc has no properties

Comment 1

[Marc Loiselle]

Attachment: This patch seems to correct the problem.

Comment 2

[HJ]

Confirming on 2001051208 and that patch seems to fix the problem.

Comment 3

[Mike Shaver (:shaver emeritus)]

sr=shaver (the code looks clean, it's a minimal fix).  Pink, is it the _right_ fix?

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

r=dbaron on the patch.  This looks like a merge error in gerv's changes for bug
25071 against heikki's change removing the baseURI property.

But supposedly baseURI should be implemented again now, so we should be able to
undo rev. 1.18...

Comment 5

[Gervase Markham [:gerv]]

Does this mean I screwed up, or CVS did? If it was me, apologies.

Gerv

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

It looks like the new implementation of baseURI isn't ready yet, so this is
probably the right thing to do.

Gerv:  I think your second patch on bug 25071 wasn't merged properly (the
parameters to makeURLAbsolute changed in revision 1.18 of nsContextMenu.js).  Do
you agree that this patch is the right thing to do?

Comment 7

[Gervase Markham [:gerv]]

That patch is now fingered as being wrong in at least two ways. <sigh> It's all
a learning process.

I didn't mean to change those lines, so reverting the changes seems sane to me.

Gerv

Comment 8

[Mike Pinkerton (not reading bugmail)]

this so isn't toolkit

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Patch checked in 2001-05-12 14:19 PST.  (nsContextMenu.js, rev 1.22).

Marc Loiselle:  Thanks for the patch.

Comment 10

[sairuh (rarely reading bugmail)]

vrfy fixed using 2001.05.29.08 comm bits on linux.