Closed Bug 804827 Opened 7 years ago Closed 7 years ago

can't access dead object in forms.js line 49

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-basecamp:-, firefox18 fixed, firefox19 fixed)

RESOLVED FIXED
blocking-basecamp -
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(1 file, 1 obsolete file)

I can't exactly reproduce this but saw this in some logs. If the focusedElement is set and its document goes away in the meantime (crash or close?), the wrapper will be dead and this will yield an error on next access.

Requesting blocking+ as this might render any input element interaction and other stuff impossible until the device is rebooted.
Attachment #674437 - Flags: review?(dflanagan)
Small correction.
Attachment #674437 - Attachment is obsolete: true
Attachment #674437 - Flags: review?(dflanagan)
Attachment #674439 - Flags: review?(dflanagan)
Component: Gaia → General
Hardware: ARM → All
Comment on attachment 674439 [details] [diff] [review]
check if the wrapper is dead before accessing it

Review of attachment 674439 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch. I can see how this.focusedElement would have a longer lifetime than the element to which it refers.  I have no experience with Cu.isDeadWrapper(), but it sounds like this is exactly what you need to detect that issue.
Attachment #674439 - Flags: review?(dflanagan) → review+
Waiting for an approval-mozilla-aurora flag.
Depends on: 804945
Comment on attachment 674439 [details] [diff] [review]
check if the wrapper is dead before accessing it

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: This might render any input element interaction and other stuff impossible until the device is rebooted.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Small, self-contained patch that adds error checking. Low risk.
String or UUID changes made by this patch: None
Attachment #674439 - Flags: approval-mozilla-aurora?
Comment on attachment 674439 [details] [diff] [review]
check if the wrapper is dead before accessing it

Review of attachment 674439 [details] [diff] [review]:
-----------------------------------------------------------------

Make sure to mark as status-firefox18:fixed when landing
Attachment #674439 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Fabrice says we should take this fix but not block on it.
blocking-basecamp: ? → -
Tim, we usually push to inbound for b2g, not to fx-team.
I know but I don't have an inbound checkout. I usually push to fx-team and merge to m-c from there. Shouldn't make a difference.
https://hg.mozilla.org/mozilla-central/rev/6c5e1a6e2e71
https://hg.mozilla.org/mozilla-central/rev/a60c5629e19b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Duplicate of this bug: 798193
You need to log in before you can comment on or make changes to this bug.