The default bug view has changed. See this FAQ.

add preferences for sets of CSS prefixed properties

RESOLVED FIXED in mozilla19

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

(Blocks: 2 bugs, {dev-doc-needed})

Trunk
mozilla19
dev-doc-needed
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
I want to add preferences for sets of prefixed properties (which are going to be among the more difficult prefixes to get rid of) as a way to ease the path towards disabling those prefixes.  This will allow:
 * authors (or other testers) to test what happens when the prefixed property support is removed
 * easy landing and backout of the final patch in case we have to slip it across releases
(Assignee)

Comment 1

5 years ago
Created attachment 674585 [details] [diff] [review]
Add preferences (defaulting to enabled, for now) to control whether certain prefixed aliases for CSS properties are supported, so that authors can have a way to test what happens when they're turned off in advance of our disabling them.  ()
Attachment #674585 - Flags: review?(bzbarsky)
Comment on attachment 674585 [details] [diff] [review]
Add preferences (defaulting to enabled, for now) to control whether certain prefixed aliases for CSS properties are supported, so that authors can have a way to test what happens when they're turned off in advance of our disabling them.  ()

r=me
Attachment #674585 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3d0e95c83ee

Updated

5 years ago
Blocks: 775235
https://hg.mozilla.org/mozilla-central/rev/f3d0e95c83ee

Should this have tests?
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla19

Updated

5 years ago
Blocks: 806068

Updated

4 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 5

4 years ago
FWIW, I plan to blog about this (assuming I remember) after it hits the release channel.
(Assignee)

Comment 6

4 years ago
Created attachment 718188 [details] [diff] [review]
, patch 2:  Also condition @-moz-keyframes parsing on the animations preference.
Attachment #718188 - Flags: review?(bzbarsky)
(Assignee)

Comment 7

4 years ago
Blog post:  http://dbaron.org/log/20130225-removing-prefixes

Comment 8

4 years ago
Ms2ger discovered (and I verified) that turning this on breaks styling of tabs in Firefox 20. :-(

Updated

4 years ago
Blocks: 845245
Comment on attachment 718188 [details] [diff] [review]
, patch 2:  Also condition @-moz-keyframes parsing on the animations preference.

r=me
Attachment #718188 - Flags: review?(bzbarsky) → review+
> turning this on breaks styling of tabs in Firefox 20. :-(

Not surprising; our UI has a tendency to use -moz-prefixed stuff before the unprefixed versions are available.

The good news is that we can easily search-and-replace our UI. ;)
(In reply to David Baron [:dbaron] (don't cc:, use needinfo? instead) from comment #7)
> Blog post:  http://dbaron.org/log/20130225-removing-prefixes

Added the link: https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_19
(Assignee)

Comment 12

4 years ago
patch 2 landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ff3de859ce3
(Assignee)

Comment 13

4 years ago
er, backed out, because it depended on unlanded patches:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc6c725d463d
(Assignee)

Updated

4 years ago
Depends on: 849656
If this is backed out it probably should not be set to RESOLVED FIXED.
(Assignee)

Comment 15

4 years ago
The bulk of it is still fixed, just the one thing I missed that's not.
(Assignee)

Comment 16

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5f4ef33fa06
https://hg.mozilla.org/mozilla-central/rev/f5f4ef33fa06
You need to log in before you can comment on or make changes to this bug.