Closed Bug 849656 Opened 8 years ago Closed 8 years ago

make CSS property aliases a little more like regular properties

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: dbaron, Assigned: dbaron)

References

(Blocks 2 open bugs)

Details

Attachments

(4 files)

I started this work for bug 774169, then relabeled it as for bug 784461 when I decided it wasn't needed for bug 774169, and it now turns out I need it for patch 2 in bug 804944.

I'd like to make CSS property aliases a little more like CSS properties, in particular, by giving them IDs in the nsCSSProperty enum after the shorthands, and making their names and enabled state work like normal properties.
Note that this uses the method_ field of the CSS_PROP_ALIAS macro, which
is not consistent in style with the other values of nsCSSProperty.
However, these enum values are unlikely to be used explicitly, and it
avoids having to add an extra parameter to the macro.  (It might even be
better to change the other values to work this way.)
Attachment #723239 - Flags: review?(bzbarsky)
Assignee: nobody → dbaron
(In reply to David Baron [:dbaron] (don't cc:, use needinfo? instead) from comment #1)
> avoids having to add an extra parameter to the macro.  (It might even be
> better to change the other values to work this way.)

Filed bug 849657 on this; interested in thoughts there.
Comment on attachment 723239 [details] [diff] [review]
Add ids for CSS property aliases to the nsCSSProperty enum.  (, patch 1)

r=me
Attachment #723239 - Flags: review?(bzbarsky) → review+
Comment on attachment 723241 [details] [diff] [review]
Move names for aliases from gAliases into kCSSRawProperties.  (, patch 2)

r=me
Attachment #723241 - Flags: review?(bzbarsky) → review+
Comment on attachment 723242 [details] [diff] [review]
Move enabled state for aliases from gAliases to gPropertyEnabled.  (, patch 3)

r=me
Attachment #723242 - Flags: review?(bzbarsky) → review+
Comment on attachment 723243 [details] [diff] [review]
Make gAliases be just an array of ids.  (, patch 4)

r=me
Attachment #723243 - Flags: review?(bzbarsky) → review+
You need to log in before you can comment on or make changes to this bug.