849656 - make CSS property aliases a little more like regular properties

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I started this work for bug 774169, then relabeled it as for bug 784461 when I decided it wasn't needed for bug 774169, and it now turns out I need it for patch 2 in bug 804944.

I'd like to make CSS property aliases a little more like CSS properties, in particular, by giving them IDs in the nsCSSProperty enum after the shorthands, and making their names and enabled state work like normal properties.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Add ids for CSS property aliases to the nsCSSProperty enum. (, patch 1)

Note that this uses the method_ field of the CSS_PROP_ALIAS macro, which
is not consistent in style with the other values of nsCSSProperty.
However, these enum values are unlikely to be used explicitly, and it
avoids having to add an extra parameter to the macro.  (It might even be
better to change the other values to work this way.)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Move names for aliases from gAliases into kCSSRawProperties. (, patch 2)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Move enabled state for aliases from gAliases to gPropertyEnabled. (, patch 3)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Make gAliases be just an array of ids. (, patch 4)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to David Baron [:dbaron] (don't cc:, use needinfo? instead) from comment #1)
> avoids having to add an extra parameter to the macro.  (It might even be
> better to change the other values to work this way.)

Filed bug 849657 on this; interested in thoughts there.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 723239 [details] [diff] [review]
Add ids for CSS property aliases to the nsCSSProperty enum.  (, patch 1)

r=me

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 723241 [details] [diff] [review]
Move names for aliases from gAliases into kCSSRawProperties.  (, patch 2)

r=me

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 723242 [details] [diff] [review]
Move enabled state for aliases from gAliases to gPropertyEnabled.  (, patch 3)

r=me

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 723243 [details] [diff] [review]
Make gAliases be just an array of ids.  (, patch 4)

r=me

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e246322a8026
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/fa369a860f47
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c3b5d2b71152
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/8d62f3d758b7

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e246322a8026
https://hg.mozilla.org/mozilla-central/rev/fa369a860f47
https://hg.mozilla.org/mozilla-central/rev/c3b5d2b71152
https://hg.mozilla.org/mozilla-central/rev/8d62f3d758b7