805017 - Disable screen timeout when DOMFullscreen is enabled

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Johnny Stenback (:jst)]

Does this patch cover the case where we're forced out of full screen mode in some way other than by the setFullScreen(false) being called from JS? I.e. what if I do w = window.open(...), that window ends up in full screen mode, then in the midst of that I call w.close(). Seems we need to do this a bit deeper down in this code, maybe in nsDocument's fullscreen handling code? Cc:ing cpearce as he wrote most of this stuff.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Johnny Stenback (:jst, [e-mail]) from comment #2)
> Does this patch cover the case where we're forced out of full screen mode in
> some way other than by the setFullScreen(false) being called from JS?

I think we'll cover those cases.

We exit fullscreen (and call nsGlobalWindow::SetFullscreenInternal()) in nsDocument::OnPageHide(), so provided that's called on whatever path we're taking we should be fine.

We do this on the close fullscreen window and document navigation cases at least.

Brad: Will this patch disable the screen saver on desktop platforms, or do we still need to implement platform specific backends for desktop platforms?

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

I don't think we have implementations for desktop platforms. 

Not sure how up to date this is, but it says it isn't planned for desktop or Android [https://wiki.mozilla.org/WebAPI] even though we have an impl for Android.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/18da095f136a