805138 - Use "mochitest-N" across the board rather than "mochitest(s)?-N(\/Z)?"

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

Buildernames currently used include:
* mochitest-N
* mochitests-N/T
* mochitest-other
* mochitest-browser-chrome

and now on Cedar (post bug 804026):
* mochitests-N

We should:
(a) Stick to always using the singular form (like we do for reftest/crashtest etc)
(b) Get rid of the forward slash onwards

This bug will make the buildbot related changes & I'll file dependants for TBPL/OrangeFactor etc.

Comment 1

[Aki Sasaki (not active)]

Attachment: singular mochitest

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 674857 [details] [diff] [review]
singular mochitest

lgtm

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 674857 [details] [diff] [review]
singular mochitest

Thank you for the patch - unfortunately I didn't realise you were also working on this (I'd set myself as the assignee when filing, though this is probably not very clear in the bugmail), so have been creating patches myself too. The patches I have change the naming everywhere, rather than just in mozharness so are a superset of this one. Hope this didn't waste too much of your time, sorry!

Comment 4

[Ed Morley [:emorley]]

Attachment: buildbotcustom v1

* Gets rid of the forward slash suffix
* Updates the trychooser tests to match the new output from this patch and the others in the series
* Also removes the forward slashes from reftests in the trychooser tests, given that they've been gone for a while now

Comment 5

[Ed Morley [:emorley]]

Attachment: buildbot-configs v1

Comment 6

[Ed Morley [:emorley]]

Attachment: buildapi v1

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 675101 [details] [diff] [review]
buildbotcustom v1

We may also need to fix the try chooser logic here:
http://hg.mozilla.org/build/buildbotcustom/file/a2afae086fe0/try_parser.py#l27

Comment 8

[Ed Morley [:emorley]]

Attachment: buildbotcustom v2

Ah yes, try_parser.py did need changing too (only difference from the v1 patch).

I've taken out the mochitest-N special-casing, since the suite names will now be covered by the else clause :-)

Requesting re-review for sanity check.

Comment 9

[Aki Sasaki (not active)]

Comment on attachment 675209 [details] [diff] [review]
buildbotcustom v2

I *think* that's good.

Comment 10

[Ed Morley [:emorley]]

Thank you :-)

https://hg.mozilla.org/build/buildbotcustom/rev/6d3d085eb0dd
https://hg.mozilla.org/build/buildbot-configs/rev/0d2accf9795e
https://hg.mozilla.org/build/buildapi/rev/33a9bfaf6264

Comment 11

[[e-mail] (:bhearsum)]

In production.

Comment 12

[Ed Morley [:emorley]]

Thank you :-)