806995 - b2g_emulator_unittest.py: error: option --test-suite: invalid choice: 'mochitest' (choose from 'reftests', 'mochitests')

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

After bug 805138 (specifically https://bugzilla.mozilla.org/attachment.cgi?id=675105&action=diff#a/mozilla-tests/b2g_config.py_sec3), we call b2g_emulator_unittest.py with '--test-suite mochitest' rather than '--test-suite mochitests'.

We should either update b2g_emulator_unittest.py to take mochitest, or else partially revert that hunk from bug 805138.

I would quite like to stick to 'mochitest' throughout, but we use 'reftests' in mozharness - so unless we change that too, we'll be inconsistent.

aki any preference?

Comment 1

[Ed Morley [:emorley]]

Example bustage:
https://tbpl.mozilla.org/php/getParsedLog.php?id=16588601&tree=Cedar

Comment 2

[Aki Sasaki (not active)]

We're going singular.

Comment 3

[Ed Morley [:emorley]]

Attachment: mozharness part v1

Switching all to singular as discussed on IRC.

(buildbot part for reftest change coming up)

Comment 4

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley UTC+0] from comment #3)
> (buildbot part for reftest change coming up)

Scratch that, there isn't one to change yet :-)

Comment 5

[Aki Sasaki (not active)]

(In reply to Ed Morley [:edmorley UTC+0] from comment #4)
> (In reply to Ed Morley [:edmorley UTC+0] from comment #3)
> > (buildbot part for reftest change coming up)
> 
> Scratch that, there isn't one to change yet :-)

Correct.

Comment 7

[Ed Morley [:emorley]]

Thank you for the review :-)

https://hg.mozilla.org/build/mozharness/rev/9e675c6b8c81