805473 - Notify app developers they need to add marketplace.firefox.com to manifest's installs_allowed

Status: VERIFIED FIXED

(Marketplace Graveyard :: Admin Tools, defect, P2)

Description

[Andrew Williamson [:eviljeff]]

from bug 799563

"We currently redirect marketplace.firefox.com to where the marketplace actually lives on marketplace.mozilla.org.  We need that to be reversed so marketplace.mozilla.org becomes the redirect."

and "installs_allowed in the manifest will need updating in the docs (and the validator too). We could run a quick script see how many manifests set this and then contact those developers and let them know."

This needs to happen before (at least a week really) to avoid breaking app installation.

Comment 1

[Wil Clouser [:clouserw]]

Andy - do you have time for this?  Target is all active developers of active apps which have marketplace.mozilla.org specified in their manifest.  I'll get copy.

Comment 2

[Jason Smith [:jsmith]]

(In reply to Wil Clouser [:clouserw] from comment #1)
> Andy - do you have time for this?  Target is all active developers of active
> apps which have marketplace.mozilla.org specified in their manifest.  I'll
> get copy.

Guys - Can we please hold on this until we resolve the contention issues brought up in bug 804634? I'd really rather avoid doing outreach when a plan could change, as that sends a bad message to top apps if we say one thing, then quickly change our minds to the other.

I also don't know right now if it's valid that we can even specify marketplace.firefox.com and marketplace.mozilla.org in the installs_allowed_from field, given that one will involve a redirect to a different origin. I need to find out if that's even allowed for redirects (which I doubt it is).

Comment 3

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #2)
> (In reply to Wil Clouser [:clouserw] from comment #1)
> > Andy - do you have time for this?  Target is all active developers of active
> > apps which have marketplace.mozilla.org specified in their manifest.  I'll
> > get copy.
> 
> Guys - Can we please hold on this until we resolve the contention issues
> brought up in bug 804634? I'd really rather avoid doing outreach when a plan
> could change, as that sends a bad message to top apps if we say one thing,
> then quickly change our minds to the other.
> 
> I also don't know right now if it's valid that we can even specify
> marketplace.firefox.com and marketplace.mozilla.org in the
> installs_allowed_from field, given that one will involve a redirect to a
> different origin. I need to find out if that's even allowed for redirects
> (which I doubt it is).

Btw - you guys are good to move forward. Contention issues are resolved.

Comment 4

[Wil Clouser [:clouserw]]

...back to on hold

Comment 5

[Andy McKay]

Can I get some text for the mail please?

Comment 6

[Jason Smith [:jsmith]]

(In reply to Andy McKay [:andym] from comment #5)
> Can I get some text for the mail please?

See comment 4. We're on hold until we get a mitigation strategy clearly defined for how to migrate over to marketplace.firefox.com safely, which currently, isn't figured out yet.

Comment 7

[Andy McKay]

Wip ready for change.

https://github.com/andymckay/zamboni/commit/e722cb

Comment 8

[Wil Clouser [:clouserw]]

https://etherpad.mozilla.org/apps-url-change-email is what I've got so far.  Happy to have improvements.

Comment 9

[Andy McKay]

https://github.com/mozilla/zamboni/commit/6a8cb8

The management command is there and ready to run, to do as a dry run:

  manage.py domain_change

To actually send the mails:

  manage.py domain_change --mail

For whenever we are ready.

Comment 10

[Andrew Williamson [:eviljeff]]

btw: https://github.com/eviljeff/app-validator/commit/1ba11bb266684c26c0559651592751730bba97b5 | https://github.com/mozilla/app-validator/pull/1/

(should probably be a new bug)

Comment 11

[Wil Clouser [:clouserw]]

Mail has been sent.  96 recipients.

Comment 12

[krupa raj[:krupa]]

closing this based on comment 11