Last Comment Bug 805565 - IndexedDB warningQuota should be turned off for Android web apps
: IndexedDB warningQuota should be turned off for Android web apps
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All Android
-- normal (vote)
: Firefox 19
Assigned To: cscott
: Sebastian Kaspari (:sebastian)
: 796321 (view as bug list)
Depends on:
  Show dependency treegraph
Reported: 2012-10-25 12:27 PDT by cscott
Modified: 2012-11-16 19:05 PST (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Proposed patch to match desktop webapp permissions. (1.22 KB, patch)
2012-10-25 12:46 PDT, cscott
wjohnston2000: review+
Details | Diff | Splinter Review

Description User image cscott 2012-10-25 12:27:06 PDT
Bug 757678 turned off the indexeddb warningQuota for desktop apps, and bug 711358 turned it off for b2g apps.  It should also be turned off for Android web apps.  Looks like an easy four-line (or so) patch, judging from the patch attached to bug 757678.
Comment 1 User image cscott 2012-10-25 12:43:02 PDT
Hm, I think that the 'offline-app' permission should also be given to webapps?  At least that's included in the context for (which fixed bug 757678, this bug's equivalent for desktop web apps).
Comment 2 User image cscott 2012-10-25 12:46:07 PDT
Created attachment 675250 [details] [diff] [review]
Proposed patch to match desktop webapp permissions.
Comment 3 User image Wesley Johnston (:wesj) 2012-10-28 12:50:22 PDT
*** Bug 796321 has been marked as a duplicate of this bug. ***
Comment 4 User image Mark Finkle (:mfinkle) (use needinfo?) 2012-10-30 21:34:42 PDT
cscott - You will need to convert the patch into something a check-in helper can land. If Wes has time, maybe he will just make the changes locally and land it. If that is the case, Wes only needs your name and email.
Comment 5 User image Kartikaya Gupta ( 2012-10-31 07:16:27 PDT
Tip: you can use

git show -M -C --binary --format="# HG changeset patch%n# User %an <%ae>%n%B" -U8

to export a patch that looks like it came from hg
Comment 6 User image Wesley Johnston (:wesj) 2012-11-16 12:30:46 PST
Whoops. Lost this for a bit, but pushed it now
Comment 7 User image Ryan VanderMeulen [:RyanVM] 2012-11-16 19:05:50 PST

Note You need to log in before you can comment on or make changes to this bug.