805573 - Day view (or Today) panes should automatically display first event within view instead of starting at midnight

Status: RESOLVED DUPLICATE of bug 1023663

(Firefox OS Graveyard :: Gaia::Calendar, defect, P3)

Description

[Aaron Train [:aaronmt]]

Currently, when I open the Calendar, I wish to see all the events I have for the day. I have plenty of events which begin in the afternoon and I am required to scroll from midnight (12:00AM), all the way down. The current day should automatically scroll to the first event of the day and have it within view on the screen.

Comment 1

[mathieu]

I'll have a patch for that soon. But I have a question:
if there is no event that day, do we still want to start at midnight? 8 AM might more reasonable IMHO

Comment 2

[mathieu]

Attachment: fix, which start at 8AM if day is empty

Comment 3

[Casey Yee]

Should start at current time of the date selected.

Comment 4

[mathieu]

@Casey, even if it's not the current day?

Comment 5

[Neeraj]

Attachment: Proposed patch for this bug.

Hello James,

Please help me by reviewing this attached patch(https://github.com/mozilla-b2g/gaia/pull/10638) :)

Thanks,

Comment 6

[James Lal [:lightsofapollo]]

Comment on attachment 767724 [details] [diff] [review]
Proposed patch for this bug.

Hi!

Thanks for working on this- I left some comments on github. When your ready for another round of review please set the review flag again.

Comment 7

[Neeraj]

Comment on attachment 767724 [details] [diff] [review]
Proposed patch for this bug.


Hello James,

Thanks for reviewing the patch :)

I have incorporated changes as per your suggestions. Please review it again and let me know if any change is required.

Regards,

Comment 8

[James Lal [:lightsofapollo]]

Comment on attachment 767724 [details] [diff] [review]
Proposed patch for this bug.

Looks good! Final step is to write some tests... Please flag me again after you have some test coverage for the new methods and we should be good to land I think... Please reach out to me on IRC (or in the gaia channel in general) if you need help... Also see the gaia README.md

Comment 9

[Neeraj]

Comment on attachment 767724 [details] [diff] [review]
Proposed patch for this bug.


Hello James,

I have written a test case for changes as per your suggestions. Please review it  and let me know if any change is required. :)

Regards,

Comment 10

[James Lal [:lightsofapollo]]

Comment on attachment 767724 [details] [diff] [review]
Proposed patch for this bug.

Sorry for the delay and thank you for this! I have a few small comments then we should be good to land this.

Comment 11

[Adam Rogers (:arog)]

What's the status of this bug?