805662 - WebRTC unit-test crash [@AudioSendAndReceive::GenerateMusic]

Status: VERIFIED FIXED

(Core :: WebRTC, defect, P2)

Description

[Christoph Diehl [:posidron]]

Attachment: callstack

Run: $OBJ_DIR/media/webrtc/signaling/test/mediaconduit_unittests --gtest_filter=TransportConduitTest.TestDummyAudioWithTransport


  for(i=0;i<2880;i++)
  {
    buf[i*2]=buf[(i*2)+1]=0;
  }

Tested with mc-central changeset: 111356:3b506ada9ef9

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Ok, this was my mistake in bug 803881

I misunderstood this code, it really did want 10 seconds of music.

I'll flip up a patch in a sec that should fix both bugs

Comment 2

[Jason Smith [:jsmith]]

No crashtest necessary, as this is covered by a unit test.

Comment 3

[Eric Rescorla (:ekr)]

Attachment: , Crash in mediaconduit_unittest,

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 684469 [details] [diff] [review]
, Crash in mediaconduit_unittest,

Review of attachment 684469 [details] [diff] [review]:
-----------------------------------------------------------------

My apologies - I had a patch in a queue on my Mac, but forgot to push it to bugzilla.

r+=me

Comment 5

[Eric Rescorla (:ekr)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db5efb6ea448

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db5efb6ea448