Closed Bug 805753 Opened 7 years ago Closed 7 years ago

Gtk 2.10 compat layer misses gtk_widget_set_has_window

Categories

(Core :: Widget: Gtk, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: mcsmurf, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 794285 added a new source compat layer for building with GTK 2.10. Bug 793501 added two new functions, which are provided by gtk 2.18 and above:
gtk_widget_get_has_window and
gtk_widget_set_has_window

So the gtk 2.10 src compat layer should be fixed to include those two functions.
Linux x86_64 comm-central lightning build is currently broken due to this error: https://tinderbox.mozilla.org/showlog.cgi?log=CalendarTrunk/1351245600.1351248498.23652.gz#err0
OS: Windows 7 → Linux
Attached patch Fix compat layer (obsolete) — Splinter Review
I don't have a pre gtk2.18 box to test this against.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #675857 - Flags: feedback?(philip.chee)
Attachment #675857 - Flags: feedback?(karlt)
Comment on attachment 675857 [details] [diff] [review]
Fix compat layer

> static inline void
>+gtk_widget_set_has_window(GtkWidget *widget, gboolean has_window)
>+{
>+  if (has_window)
>+    GTK_WIDGET_UNSET_FLAGS (widget, GTK_WIDGET_NO_WINDOW);
>+  else
>+    GTK_WIDGET_SET_FLAGS (widget, GTK_WIDGET_NO_WINDOW);
>+}
>+
>+static inline void

Need to use GTK_NO_WINDOW for the flag.
(GTK_WIDGET_NO_WINDOW is the test macro.)
Otherwise this is what is needed.
Attachment #675857 - Flags: feedback?(philip.chee)
Attachment #675857 - Flags: feedback?(karlt)
Attachment #675857 - Flags: feedback+
Attachment #675857 - Attachment is obsolete: true
Attachment #675959 - Flags: review?(roc)
Attachment #675959 - Flags: feedback+
Comment on attachment 675959 [details] [diff] [review]
Revised compat layer fix [Checked in: Comment 6]

Review of attachment 675959 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/gtk2/compat/gtk/gtkwidget.h
@@ +98,5 @@
> +{
> +  if (has_window)
> +    GTK_WIDGET_UNSET_FLAGS (widget, GTK_NO_WINDOW);
> +  else
> +    GTK_WIDGET_SET_FLAGS (widget, GTK_NO_WINDOW);

{}
Attachment #675959 - Flags: review?(roc) → review+
Comment on attachment 675959 [details] [diff] [review]
Revised compat layer fix [Checked in: Comment 6]

https://hg.mozilla.org/mozilla-central/rev/f161ad73100b
Attachment #675959 - Attachment description: Revised compat layer fix → Revised compat layer fix [Checked in: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.