805766 - [TSF] TSF isn't available on designMode editor

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

TSF isn't available on designMode editor if focus is moved from another document. If Fx is activated when designMode editor has focus, then, it's available.

The cause is nsFocusManager doesn't call nsIMEStateManager::OnFocusChange() from here:

http://mxr.mozilla.org/mozilla-central/source/dom/base/nsFocusManager.cpp#1766

Then, nsIMEStateManager will try to create nsTextStateManager with old focused presContext and fail it.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The patch for this also fixes bug 789881!

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

I found a bug when I wrote the tests. checkbox, radio button, file input and both types of <select> are focusable even in contenteditable element, but focus event is never fired on the elements.

Comment 3

[Neil Deakin]

Comment on attachment 676838 [details] [diff] [review]
Patch

You shouldn't be calling CheckIfFocusable here as it can be expensive as it flushes (see bug 792297). You don't need to though, as it should always return true.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Is this enough?

Comment 5

[Neil Deakin]

I'm a bit unclear what this patch is doing. The code you changed only focuses the document and may not focus aContent, yet you pass aContent to OnChangeFocus. Did you mean to pass null?

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

(In reply to Neil Deakin from comment #5)
> I'm a bit unclear what this patch is doing. The code you changed only
> focuses the document and may not focus aContent, yet you pass aContent to
> OnChangeFocus. Did you mean to pass null?

Ah, okay. How about this.

The problem is, editor's focus event handler try creating nsTextStateManager instance. At this time, IME state must match with the new IME state which is expected by the new focused content.

If the getting focus editor is a designMode editor, the document's focus event would be used by the editor for doing above. At this time, the blurred content is stored in nsIMEStateManager since nsFocusManager doesn't call nsIMEStateManager::OnFocusChange() before dispatching the focus event of document.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5042f0a60460

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5042f0a60460

Comment 9

[(no longer active)]

This seems to have caused bug 808287, which is pretty serious.  I've backed this patch out for now to see if the backout fixes bug 808287.

https://hg.mozilla.org/integration/mozilla-inbound/rev/70f7e6ce95b8

Comment 10

[Ed Morley [:emorley]]

(In reply to Ehsan Akhgari [:ehsan] from comment #9)
> This seems to have caused bug 808287, which is pretty serious.  I've backed
> this patch out for now to see if the backout fixes bug 808287.
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/70f7e6ce95b8

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/70f7e6ce95b8

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Check-in of patch posted in Bug 808287,

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6bd99bf0c1f

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b6bd99bf0c1f