805789 - Handle null and undefined as correct values instead of converted to strings on USSDReceivedEventDict::message

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Guillermo López :willyaranda (probably SLOW response)]

Should be:

DOMString ? message = null;

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Patch

Handle null and undefined as correct values and not convert them to string.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a38917528484

Comment 3

[Guillermo López :willyaranda (probably SLOW response)]

Comment on attachment 675539 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Followup bug 794011
User impact if declined: We need more checks in our USSD UI (need to check against strings like "undefined" and "null" instead of object null and undefined).
Testing completed (on m-c, etc.): m-i
Risk to taking this patch (and alternatives if risky): None
String or UUID changes made by this patch: None

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a38917528484

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c883d02a0bd9