805825 - [MMI] Follow up: handle USSD session expiration

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

This bug is a follow up for Bug 802644.
As I mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=802644#c6 once the 'sessionEnded' flag is properly added to the'USSDReceivedEvent' we should deal with it in the UI side. The only remaining platform work for it is Bug 805789.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6111

Pointer to Github pull-request

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 676969 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6111

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Follow up of Bug 802644
User impact if declined: The user would be able to introduce replies for an expired USSD session causing a confusing UX.
Testing completed: Tested with an otoro with 3 different SIM cards and different USSD interactive menus.
Risk to taking this patch (and alternatives if risky): None.

Note that I won't land this in gaia until Bug 805789 lands (I am testing with the patch applied on my build)

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 676969 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6111

Love it, pretty small change in the code.

And tons of unit test added :)

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Thanks Francisco!

https://github.com/mozilla-b2g/gaia/commit/29208770144df8d95fbc40b462acb0c67304c8d8