805989 - Icons in the overflow chat menu are incorrectly sized

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

See http://screencast.com/t/gno2njZ3gqe for a screenshot of the bug. The icon is currently being stretched to 16x16 pixels. The image that is being set there is 8x12 pixels.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 675713 [details] [diff] [review]
Patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/1323dc441e74

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: Icons in the overflow chat menu will be stretched
Testing completed (on m-c, etc.): locally, just landed on mozilla-inbound
Risk to taking this patch (and alternatives if risky): none expected
String or UUID changes made by this patch: none

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1323dc441e74

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/47be0a16be6f
https://hg.mozilla.org/releases/mozilla-beta/rev/4d4f679506c1

Comment 4

[Mihai Morar, (:MihaiMorar)]

Attachment: Screen Shot

I've tested this issue on Windows 7 x64, Ubuntu x32 and Mac 10.8, on Nightly  2012.10.26 and Firefox 17.0b6 and I could reproduce it only on Windows 7 as it shows in the attachment.
Windows 7 x64
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0
20121026030606
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
20121113065533

Ubuntu x32
Mozilla/5.0 (X11; Linux i686; rv:19.0) Gecko/19.0 Firefox/19.0
20121026030606
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0
20121113065533

Mac 10.8
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:19.0) Gecko/19.0 Firefox/19.0
20121026030606
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/17.0 Firefox/17.0
20121113065533
For all OS Firefox 17.0b6 look to not have this issue anymore.

Comment 5

[Mihai Morar, (:MihaiMorar)]

Attachment: Screen Shot

Comment 6

[u279076]

Thanks Mario. Would you be able to check the latest Aurora and Nightly builds as well?

Comment 7

[Mihai Morar, (:MihaiMorar)]

Attachment: Screen Shot

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #6)
> Thanks Mario. Would you be able to check the latest Aurora and Nightly
> builds as well?

I've tested this issue only on Windows 7 x64, because as I mentioned in Comment 4 it's the only platform I could reproduce this bug.

Nightly:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0
20121120030739

Aurora:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0
20121119042013

It looks like Social API icons are sized as expected. Please the the attachment.
Should I check latest Aurora and Nightly for Ubuntu and OS Mac too even if they worked as expected for last versions I checked in comment 4 ?

Comment 8

[u279076]

Actually, Mario, I was incorrect. This bug is not about the stretched icons in the toolbar. This is about a particular icon in the chat menu.

Jared, can you confirm your steps to reproduce this bug? I'm not clear where this icon exists in the UI.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

The steps to reproduce this bug are:

1) Resize the window to be half of the screen's width
2) Open multiple docked chats by clicking on friends names in the chat list in the Social API sidebar.
3) Open enough chats so that not all of the chats can fit in the open window.
4) A small menu will appear in the bottom-right of the browser window. This menu shows the chats that couldn't fit in the window.

The icons in this menu were the ones incorrectly sized.

Comment 10

[Mihai Morar, (:MihaiMorar)]

Attachment: Screen Shot

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #8)
> Actually, Mario, I was incorrect. This bug is not about the stretched icons
> in the toolbar. This is about a particular icon in the chat menu.
> 
> Jared, can you confirm your steps to reproduce this bug? I'm not clear where
> this icon exists in the UI.

It looks like Jared was right. I could reproduce this issue on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:19.0) Gecko/19.0 Firefox/19.0
Build id: 20121026030606
but on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0
Build id: 20121121075611 it looks that the problem was fixed. Instead of online icon from (20121026030606), in 18.0b1 it's implemented that online users name to be Bold. Hope this will help you.
Please see the attachment, in which I put screen shot for both builds.

Comment 11

[u279076]

Thanks Mario. Based on this, I consider this verified fixed.