806002 - Make nsDidReflowStatus into an enum

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Daniel Holbert [:dholbert]]

Right now, the nsDidReflowStatus type is defined as follows:

> 508 /**
> 509  * DidReflow status values.
> 510  */
> 511 typedef bool nsDidReflowStatus;
> 512 
> 513 #define NS_FRAME_REFLOW_NOT_FINISHED false
> 514 #define NS_FRAME_REFLOW_FINISHED     true
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsIFrame.h#508

We should convert it into an enum instead of a typedef, so compilers can enforce that we're using it correctly and not accidentally passing in a different type. (to prevent bugs like bug 806001)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

This patch currently breaks the build due to bug 806001 (yay, we can catch bugs!) but it builds successfully after that bug is fixed.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 675720 [details] [diff] [review]
fix

r=dbaron

Comment 4

[Daniel Holbert [:dholbert]]

Green try run, aside from a few known-intermittent-oranges:
  https://tbpl.mozilla.org/?tree=Try&rev=f08b1abd0d3d

Landed:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/74d3d6a66e7d

Comment 5

[(no longer active)]

Hmm, I wish you had made it an enum class.  :-)

Comment 6

[Daniel Holbert [:dholbert]]

I haven't dug into C++11 stuff too much yet, so I don't exactly know the distinction -- but FWIW, just making it an enum did catch some bugs (via compile errors), as noted in comment 2!

But if you think it'd help, feel free to file followup on making it an enum class if you like!

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/74d3d6a66e7d

Comment 8

[(no longer active)]

Filed bug 810355.