810355 - Convert nsDidReflowStatus into an enum class

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[(no longer active)]

Bug 806002 converted this into an enum.  We can go the extra mile to convert it into an enum class so that the compiler actually does type checking for us.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=7c538171e007

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 681371 [details] [diff] [review]
Patch (v1)

>-  target->DidReflow(mPresContext, nullptr, NS_FRAME_REFLOW_FINISHED);
>+  target->DidReflow(mPresContext, nullptr, nsDidReflowStatus::NS_FRAME_REFLOW_FINISHED);

The scoping change introduces a lot of redundancy in the naming, and makes all of these usages huge and gross.

Could you fix that by renaming these to to e.g. nsDidReflowStatus::FINISHED and ::NOT_FINISHED?

r=me with that.

Comment 4

[(no longer active)]

Sure, will do when landing.

Comment 5

[Daniel Holbert [:dholbert]]

Hmm, looks like there's one red on the Try push:
{
../../../layout/generic/nsFrame.cpp: In member function 'virtual nsresult nsFrame::DidReflow(nsPresContext*, const nsHTMLReflowState*, nsDidReflowStatus)':
../../../layout/generic/nsFrame.cpp:4199: error: cannot pass objects of non-POD type 'class nsDidReflowStatus' through '...'; call will abort at runtime
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=17019680&tree=Try

Comment 6

[(no longer active)]

Fixed by adding a static_cast.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6e9cda2871a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e6e9cda2871a