806024 - Enable Android product announcements client service

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Product Announcements, defect, P1)

Description

[Richard Newman [:rnewman]]

Let's turn this on when there's a server to hit.

Comment 1

[Richard Newman [:rnewman]]

Update for release drivers: still waiting on backend service.

Pref-on should be a single-line change, and the logic will be the same across all product versions, so I'm confident of being able to test this thoroughly against the live service before opting to turn it on for a branch.

Comment 2

[Richard Newman [:rnewman]]

Status: we have an AMI against which I have begin testing; that's revealed a server bug or two, which will be resolved by the Services team early next week.

When the next server deployment rolls out, I'll hand this over to Tracy for more thorough testing (for which I'd like the trivial changes in Bug 812809 uplifted, just to make the feature in Aurora match trunk).

In parallel, we're waiting for final hostnames to be assigned and production infrastructure deployment to be finished.

Schedule-wise, that probably means this pref-on will hit in early Beta, rather than Aurora, but we'll see. I'd much rather enable a well-tested feature in Beta than rush to enable a poorly-tested feature in Aurora before the cutoff!

Comment 3

[Richard Newman [:rnewman]]

Current status: I think we've squashed all the server bugs. Production hostname *should* go live today or Monday (Bug 803547), but in the mean time the client logs a single line of error and continues on its merry way, so I'm ready to turn this on in Beta and Aurora as soon as tracy signs off.

Comment 4

[Tracy Walker [:tracy]]

Currently, idle time doesn't work.  (thanks to rnewman for adding capability to his testing addon to spoof idle time from the client)

Once the blocker is figured out/fixed.  I'll do a complete test run against both beta and aurora for sign-off.

Comment 5

[Alex Keybl [:akeybl]]

This needs to land for Beta 6 (going to build 12/27) to make it into Firefox 18.

Comment 6

[Richard Newman [:rnewman]]

(In reply to Alex Keybl [:akeybl] from comment #5)
> This needs to land for Beta 6 (going to build 12/27) to make it into Firefox
> 18.

Testing should be complete in the next couple of days. One-line pref-on patch is ready to go.

Comment 7

[Tracy Walker [:tracy]]

I'm good with the state of this thing now that the idle state has been proven to work correctly.  The Mobile QA team wants to take a look at the feature, so I am going to work out a small test session with them sometime tomorrow, if possible.  Sign-off to come pending that testing.

Comment 8

[Richard Newman [:rnewman]]

Attachment: Pref on.

Comment 9

[Richard Newman [:rnewman]]

Flagging Tracy for final A-OK, then I'll land the pref-on patch.

Comment 10

[Tracy Walker [:tracy]]

Ok, flip the switch.

mobile QA guys had a look at it. They had a few suggestions for testing thoroughness, which I'll add to the test suite.  

Nothing further blocking this.

Comment 11

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72eead57d12c
https://hg.mozilla.org/releases/mozilla-aurora/rev/4287525881ec
https://hg.mozilla.org/releases/mozilla-beta/rev/d169db669f31

Thanks, Tracy and co!

Comment 12

[Tracy Walker [:tracy]]

for verification on production, can we use the dev channel?

Comment 13

[Richard Newman [:rnewman]]

(In reply to Tracy Walker [:tracy] from comment #12)
> for verification on production, can we use the dev channel?

If you're using a Fennec build, it will use the dev channel against the prod hostname. But bear in mind that anything you send to that channel will go to anyone running a custom build of Fennec.

In general, ensure that stage is identical to prod, and use that. But if you really, really have to verify prod, then yes, use dev.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/d169db669f31

Comment 15

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/72eead57d12c