Closed Bug 812809 Opened 8 years ago Closed 8 years ago

Adjust product announcements constants to allow for easier testing

Categories

(Android Background Services Graveyard :: Product Announcements, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox18- verified, firefox19 verified)

VERIFIED FIXED
mozilla20
Tracking Status
firefox18 - verified
firefox19 --- verified

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

(Whiteboard: [snippets])

Attachments

(1 file)

I'd like to switch some `final` constants to non-final, and extract a rate-limiting constant from AnnouncementsService to AnnouncementsConstants for easier QA.
It might be overkill to have this reviewed. Might change my mind later.
Attachment #682783 - Flags: review?(nalexander)
Marking as tracking-firefox18?, because this will make QA testing this feature much less painful. Super low risk, and would increase our confidence in the validity of testing on m-c (when it lands, of course).
Blocks: 806024
Summary: Adjust constants to allow for easier testing → Adjust product announcements constants to allow for easier testing
Whiteboard: [snippets]
Comment on attachment 682783 [details] [diff] [review]
Proposed patch. v1

Review of attachment 682783 [details] [diff] [review]:
-----------------------------------------------------------------

s/existing commit message/something that doesn't lie/, like

Replace 'static final' with 'static' for easier testing of Announcements.
Attachment #682783 - Flags: review?(nalexander) → review+
Thanks, Nick. Pushed with clearer commit message:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3ffc2519cce
Target Milestone: --- → mozilla19
https://hg.mozilla.org/mozilla-central/rev/a3ffc2519cce
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: mozilla19 → mozilla20
Comment on attachment 682783 [details] [diff] [review]
Proposed patch. v1

This is a straightforward move of a single constant (MINIMUM_FETCH_INTERVAL_MSEC), and stripping some 'final' modifiers.

Tested on m-c and local builds.

This will allow for less agonizing manual QA of product announcements feature (in 18), so I'd like it to chase the rest of the code.
Attachment #682783 - Flags: approval-mozilla-beta?
Attachment #682783 - Flags: approval-mozilla-aurora?
Attachment #682783 - Flags: approval-mozilla-beta?
Attachment #682783 - Flags: approval-mozilla-beta+
Attachment #682783 - Flags: approval-mozilla-aurora?
Attachment #682783 - Flags: approval-mozilla-aurora+
Status: RESOLVED → VERIFIED
Component: Android: Product Announcements → Product Announcements
Product: Mozilla Services → Android Background Services
You need to log in before you can comment on or make changes to this bug.