812809 - Adjust product announcements constants to allow for easier testing

Status: VERIFIED FIXED

(Android Background Services Graveyard :: Product Announcements, defect)

Description

[Richard Newman [:rnewman]]

I'd like to switch some `final` constants to non-final, and extract a rate-limiting constant from AnnouncementsService to AnnouncementsConstants for easier QA.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

It might be overkill to have this reviewed. Might change my mind later.

Comment 2

[Richard Newman [:rnewman]]

Marking as tracking-firefox18?, because this will make QA testing this feature much less painful. Super low risk, and would increase our confidence in the validity of testing on m-c (when it lands, of course).

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 682783 [details] [diff] [review]
Proposed patch. v1

Review of attachment 682783 [details] [diff] [review]:
-----------------------------------------------------------------

s/existing commit message/something that doesn't lie/, like

Replace 'static final' with 'static' for easier testing of Announcements.

Comment 4

[Richard Newman [:rnewman]]

Thanks, Nick. Pushed with clearer commit message:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3ffc2519cce

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a3ffc2519cce

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 682783 [details] [diff] [review]
Proposed patch. v1

This is a straightforward move of a single constant (MINIMUM_FETCH_INTERVAL_MSEC), and stripping some 'final' modifiers.

Tested on m-c and local builds.

This will allow for less agonizing manual QA of product announcements feature (in 18), so I'd like it to chase the rest of the code.

Comment 7

[Richard Newman [:rnewman]]

Thanks, Alex!

https://hg.mozilla.org/releases/mozilla-aurora/rev/15d4ae634345
https://hg.mozilla.org/releases/mozilla-beta/rev/b1b2dcb88242