806321 - [settings] optimize `style/icons.css'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Fabien Cazenave [:kaze]]

The `style/icons.css' stylesheets takes ~250ms to be applied to the Settings app. It should be optimized:
 • by using a sprite instead of several icons for the root panel
 • and/or by using better selectors for the root panel icons

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Hey Fabien, I'd like to work on this. How exactly did you measure the time it takes to apply the stylesheet?

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6054

Pointer to Github pull-request

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6054

Pointer to Github pull-request

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Blocking of a blocker. So I believe this is a blocking-basecamp+.

Comment 5

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

Tim, I just rebased your patch, would you review it please?

Comment 6

[Fabien Cazenave [:kaze]]

Comment on attachment 679044 [details]
patch proposal

r=me but the patch must be rebased, see my PR:
https://github.com/mozilla-b2g/gaia/pull/6054

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 679044 [details]
patch proposal

Your rebased patch in https://github.com/mozilla-b2g/gaia/pull/6227 looks good to me! That's some nice work you did there in bug 806237. The settings app comes up really fast now.