[settings] optimize `style/icons.css'

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kaze, Assigned: kaze)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: QARegressExclude)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
The `style/icons.css' stylesheets takes ~250ms to be applied to the Settings app. It should be optimized:
 • by using a sprite instead of several icons for the root panel
 • and/or by using better selectors for the root panel icons
(Assignee)

Updated

5 years ago
Blocks: 797395
Hey Fabien, I'd like to work on this. How exactly did you measure the time it takes to apply the stylesheet?
OS: Linux → All
Hardware: x86_64 → All
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Created attachment 676116 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6054

Pointer to Github pull-request
Attachment #676116 - Flags: review?(kaze)
Created attachment 676117 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6054

Pointer to Github pull-request
Attachment #676117 - Attachment is obsolete: true
Blocking of a blocker. So I believe this is a blocking-basecamp+.
blocking-basecamp: --- → +
(Assignee)

Comment 5

5 years ago
Created attachment 679044 [details]
patch proposal

Tim, I just rebased your patch, would you review it please?
Assignee: ttaubert → kaze
Attachment #676116 - Attachment is obsolete: true
Attachment #676116 - Flags: review?(kaze)
Attachment #679044 - Flags: review?(ttaubert)
(Assignee)

Comment 6

5 years ago
Comment on attachment 679044 [details]
patch proposal

r=me but the patch must be rebased, see my PR:
https://github.com/mozilla-b2g/gaia/pull/6054
Attachment #679044 - Flags: review?(ttaubert) → review+
Comment on attachment 679044 [details]
patch proposal

Your rebased patch in https://github.com/mozilla-b2g/gaia/pull/6227 looks good to me! That's some nice work you did there in bug 806237. The settings app comes up really fast now.
Attachment #679044 - Flags: review+
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
blocking-basecamp: + → ---
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 816321

Updated

5 years ago
Whiteboard: QARegressExclude
You need to log in before you can comment on or make changes to this bug.