816321 - [Settings] Keyboard icon is cropped on the right

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Open Settings
 2. Scroll down so that the "Keyboard" listing is visible.

ACTUAL RESULT:
Keyboard icon is cropped on the right side. You can tell because its corners are rounded on the left, but square on the right.

Comment 1

[Daniel Holbert [:dholbert]]

The icon is taken from this sprite-sheet (3rd row, 2nd column):
 https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/style/images/icons_sprite.png

As you can see in that sprite, all 4 of the the keyboard's corners are rounded.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot

Here's a screenshot of the (incorrectly-cropped) icon in the settings menu.

Comment 3

[Daniel Holbert [:dholbert]]

Bug 806321 added the sprite-sheet. I'm not sure if that introduced this bug, but I'm adding a dependency since they're related at least.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Thanks for noticing, Daniel. Looks like I didn't align the keyboard icon correctly.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6828

Pointer to Github pull-request

Comment 6

[Fabien Cazenave [:kaze]]

Comment on attachment 688768 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6828

nice

Comment 7

[Fabien Cazenave [:kaze]]

Comment on attachment 688768 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6828

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): ?
User impact if declined: cropped keyboard icon
Testing completed: manual
Risk to taking this patch (and alternatives if risky): none, image only

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Vivien, can you please take a short look at this? It's a very low-risk change. Alternatively Gordon could maybe merge this to the UX branch?

Comment 9

[Fabien Cazenave [:kaze]]

Tim, the PNG sprite has been updated and I think the keybord icon is OK now. Can you confirm?

Comment 10

[Daniel Holbert [:dholbert]]

Attachment: screenshot of new/fixed rendering

Looks good to me, with an up-to-date gaia in b2g desktop client!  (screenshot attached)

Comment 11

[Fabien Cazenave [:kaze]]

Thanks Daniel, closing.