Last Comment Bug 806351 - disable Notification Center support on beta (Firefox 17), it isn't ready
: disable Notification Center support on beta (Firefox 17), it isn't ready
Status: RESOLVED FIXED
:
Product: Toolkit
Classification: Components
Component: General (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Josh Aas
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-29 07:19 PDT by Josh Aas
Modified: 2012-10-29 14:53 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
+
fixed


Attachments
fix v1.0 (1.06 KB, patch)
2012-10-29 07:19 PDT, Josh Aas
doug.turner: review+
lukasblakk+bugs: approval‑mozilla‑beta+
Details | Diff | Splinter Review

Description Josh Aas 2012-10-29 07:19:31 PDT
Created attachment 676135 [details] [diff] [review]
fix v1.0

I'm not confident enough in our new Notification Center support to ship it in Firefox 17. We're putting more effort into refining alerts on OS X in upcoming releases. We should disable it on beta.
Comment 1 Doug Turner (:dougt) 2012-10-29 08:46:04 PDT
Comment on attachment 676135 [details] [diff] [review]
fix v1.0

Use a pref, maybe?
Comment 2 Josh Aas 2012-10-29 08:55:54 PDT
(In reply to Doug Turner (:dougt) from comment #1)
> Comment on attachment 676135 [details] [diff] [review]
> fix v1.0
> 
> Use a pref, maybe?

I'm not a fan of adding prefs in general, this seems too minor until it actually works well.
Comment 3 Josh Aas 2012-10-29 09:16:35 PDT
Comment on attachment 676135 [details] [diff] [review]
fix v1.0

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 728106
User impact if declined: OS X 10.8 users will have a poor Notification Center experience
Testing completed (on m-c, etc.): none
Risk to taking this patch (and alternatives if risky): not risky
String or UUID changes made by this patch: none
Comment 4 Lukas Blakk [:lsblakk] use ?needinfo 2012-10-29 11:01:09 PDT
Comment on attachment 676135 [details] [diff] [review]
fix v1.0

Approving the disabling for 17 (Beta) and marking tracking/affected for 18 as well so we can check in again in the next Beta cycle to ensure this can stay in.
Comment 5 Josh Aas 2012-10-29 13:17:12 PDT
pushed to mozilla-beta

http://hg.mozilla.org/releases/mozilla-beta/rev/9cfe29fd1612
Comment 6 Josh Aas 2012-10-29 13:17:55 PDT
Please clear the flags for Firefox 18 on this bug. This bug is only about Firefox 17, bug 805837 is about Firefox 18.

Note You need to log in before you can comment on or make changes to this bug.