Closed Bug 806568 Opened 10 years ago Closed 10 years ago

BaselineCompiler: Move IC code into its own file

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: djvj, Unassigned)

References

Details

Attachments

(3 files, 1 obsolete file)

Move the baseline IC code into its own files, and away from being in BaselineJIT.h and BaselineCompiler.cpp
Attachment #676328 - Flags: review?(jdemooij)
Comment on attachment 676328 [details] [diff] [review]
Refactor Baseline IC code into own file.

Review of attachment 676328 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #676328 - Flags: review?(jdemooij) → review+
There will be multiple IC (sub)classes, so following Ion's CodeGenerator inheritance model didn't work very well. This patch just keeps the definitions in BaselineIC.h and adds separate .cpp files for every platform. I think this is the cleanest solution here because it doesn't require multiple class definitions for every cache type.

With some extra work we should be able to make the remaining code in BaselineIC.cpp platform-independent, the code in x86-shared needs some extra work for x64 but hopefully we don't need separate x86 and x64 implementations.
Attachment #677142 - Flags: review?(kvijayan)
Comment on attachment 677142 [details] [diff] [review]
Add platform-specific files

Review of attachment 677142 [details] [diff] [review]:
-----------------------------------------------------------------

Agreed about the IC splitting.  Changes look good!
Attachment #677142 - Flags: review?(kvijayan) → review+
Attached patch Split BaselineCompiler (obsolete) — Splinter Review
This patch adds BaselineCompilerShared, BaselineCompilerX86 etc just like Ion's CodeGenerator. (Reusing this bug since it's all kinda related.)
Attachment #677352 - Flags: review?(kvijayan)
Attachment #677352 - Attachment is obsolete: true
Attachment #677352 - Flags: review?(kvijayan)
Attachment #677356 - Flags: review?(kvijayan)
Comment on attachment 677356 [details] [diff] [review]
Split BaselineCompiler

Review of attachment 677356 [details] [diff] [review]:
-----------------------------------------------------------------

Cool :)
Attachment #677356 - Flags: review?(kvijayan) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.