Closed
Bug 806568
Opened 13 years ago
Closed 13 years ago
BaselineCompiler: Move IC code into its own file
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: djvj, Unassigned)
References
Details
Attachments
(3 files, 1 obsolete file)
|
22.72 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
|
6.69 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
|
11.09 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
Move the baseline IC code into its own files, and away from being in BaselineJIT.h and BaselineCompiler.cpp
|
Reporter | |
Comment 1•13 years ago
|
||
Attachment #676328 -
Flags: review?(jdemooij)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 676328 [details] [diff] [review]
Refactor Baseline IC code into own file.
Review of attachment 676328 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #676328 -
Flags: review?(jdemooij) → review+
|
|
Reporter | |
Comment 3•13 years ago
|
||
|
|
||
Comment 4•13 years ago
|
||
There will be multiple IC (sub)classes, so following Ion's CodeGenerator inheritance model didn't work very well. This patch just keeps the definitions in BaselineIC.h and adds separate .cpp files for every platform. I think this is the cleanest solution here because it doesn't require multiple class definitions for every cache type.
With some extra work we should be able to make the remaining code in BaselineIC.cpp platform-independent, the code in x86-shared needs some extra work for x64 but hopefully we don't need separate x86 and x64 implementations.
Attachment #677142 -
Flags: review?(kvijayan)
|
|
Reporter | |
Comment 5•13 years ago
|
||
Comment on attachment 677142 [details] [diff] [review]
Add platform-specific files
Review of attachment 677142 [details] [diff] [review]:
-----------------------------------------------------------------
Agreed about the IC splitting. Changes look good!
Attachment #677142 -
Flags: review?(kvijayan) → review+
|
|
||
Comment 6•13 years ago
|
||
|
|
||
Comment 7•13 years ago
|
||
This patch adds BaselineCompilerShared, BaselineCompilerX86 etc just like Ion's CodeGenerator. (Reusing this bug since it's all kinda related.)
Attachment #677352 -
Flags: review?(kvijayan)
|
|
||
Comment 8•13 years ago
|
||
Attachment #677352 -
Attachment is obsolete: true
Attachment #677352 -
Flags: review?(kvijayan)
Attachment #677356 -
Flags: review?(kvijayan)
|
|
Reporter | |
Comment 9•13 years ago
|
||
Comment on attachment 677356 [details] [diff] [review]
Split BaselineCompiler
Review of attachment 677356 [details] [diff] [review]:
-----------------------------------------------------------------
Cool :)
Attachment #677356 -
Flags: review?(kvijayan) → review+
|
|
||
Comment 10•13 years ago
|
||
|
|
||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•