806021 - BaselineCompiler: Clean up initial patch

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Kannan Vijayan [:djvj]]

Clean up Jan's initial baseline compiler patch to be less hackily patched in.

Comment 1

[Kannan Vijayan [:djvj]]

Attachment: Add --enable-baseline flag, ENABLE_BASELINE makefile definition, and JS_BASELINE #define

This isn't hooked up to anything yet.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 675852 [details] [diff] [review]
Add --enable-baseline flag, ENABLE_BASELINE makefile definition, and JS_BASELINE #define

Review of attachment 675852 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/configure.in
@@ +2206,5 @@
>      ;;
>  esac
>  
> +MOZ_ARG_ENABLE_BOOL(baseline,
> +[  --enable-baseline  Enable use of the Baseline JIT],

For simplicity it seems best to match JM and Ion and use --disable-baseline instead.

Comment 3

[Tom S]

I really would like to see the patch to move the baseline jit to its own directory.

Comment 4

[Kannan Vijayan [:djvj]]

I think to avoid daily merge issues, it's best to keep that until one final push at the end.  I agree that it feels kinda icky to have things in the ion directory though.

Comment 5

[Kannan Vijayan [:djvj]]

This bug is no longer relevant.  Baseline has been cleaned up, fixed, and landed.