Closed Bug 806021 Opened 9 years ago Closed 8 years ago

BaselineCompiler: Clean up initial patch

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: djvj, Assigned: djvj)

References

Details

Attachments

(1 file)

Clean up Jan's initial baseline compiler patch to be less hackily patched in.
Assignee: general → kvijayan
This isn't hooked up to anything yet.
Attachment #675852 - Flags: review?(jdemooij)
Comment on attachment 675852 [details] [diff] [review]
Add --enable-baseline flag, ENABLE_BASELINE makefile definition, and JS_BASELINE #define

Review of attachment 675852 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/configure.in
@@ +2206,5 @@
>      ;;
>  esac
>  
> +MOZ_ARG_ENABLE_BOOL(baseline,
> +[  --enable-baseline  Enable use of the Baseline JIT],

For simplicity it seems best to match JM and Ion and use --disable-baseline instead.
Attachment #675852 - Flags: review?(jdemooij)
Depends on: 806415
I really would like to see the patch to move the baseline jit to its own directory.
I think to avoid daily merge issues, it's best to keep that until one final push at the end.  I agree that it feels kinda icky to have things in the ion directory though.
Depends on: 806568
Depends on: 818231
Depends on: 818960
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
This bug is no longer relevant.  Baseline has been cleaned up, fixed, and landed.
You need to log in before you can comment on or make changes to this bug.