BaselineCompiler: Clean up initial patch

RESOLVED WONTFIX

Status

()

defect
RESOLVED WONTFIX
7 years ago
6 years ago

People

(Reporter: djvj, Assigned: djvj)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Clean up Jan's initial baseline compiler patch to be less hackily patched in.
(Assignee)

Updated

7 years ago
Assignee: general → kvijayan
(Assignee)

Comment 1

7 years ago
This isn't hooked up to anything yet.
Attachment #675852 - Flags: review?(jdemooij)
Comment on attachment 675852 [details] [diff] [review]
Add --enable-baseline flag, ENABLE_BASELINE makefile definition, and JS_BASELINE #define

Review of attachment 675852 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/configure.in
@@ +2206,5 @@
>      ;;
>  esac
>  
> +MOZ_ARG_ENABLE_BOOL(baseline,
> +[  --enable-baseline  Enable use of the Baseline JIT],

For simplicity it seems best to match JM and Ion and use --disable-baseline instead.
Attachment #675852 - Flags: review?(jdemooij)
Depends on: 806415
I really would like to see the patch to move the baseline jit to its own directory.
(Assignee)

Comment 4

7 years ago
I think to avoid daily merge issues, it's best to keep that until one final push at the end.  I agree that it feels kinda icky to have things in the ion directory though.
(Assignee)

Updated

7 years ago
Depends on: 806568
(Assignee)

Updated

7 years ago
Depends on: 818231
(Assignee)

Updated

7 years ago
Depends on: 818960
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
(Assignee)

Comment 5

6 years ago
This bug is no longer relevant.  Baseline has been cleaned up, fixed, and landed.
You need to log in before you can comment on or make changes to this bug.