806648 - Toggling keyboard symbol layout while shifted resets SHIFT key icon, but text input is now caps locked

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P3)

Description

[Chris Peterson [:cpeterson]]

STR
1. Open browser app
2. Open a web page where you can type, such as the Bing search field
3. Press SHIFT key
4. See blue arrow indicating shifted state
5. Press "?123" button twice to toggle into and out of symbol layout
6. Type some more letters

RESULT:
The letters are all uppercase, as if caps lock is on, but the SHIFT key is not indicating a shifted or caps lock state with a blue arrow.

On the Android stock VKB, toggling the symbol layout while shifted clears the shift state. Toggling the symbol layout while caps lock is enabled leaves caps lock enabled.

Comment 1

[John Shih]

I can confirm this
build info
2012-10-30
gaia master: 1a8a2add26b6130eee8cea29c6a8768bb2835741
gecko: a17fb13630fcac0a9a222c1130e4a5933277e30c

Comment 2

[John Shih]

Rudy, 
can you take a look at this?

Comment 3

[David Flanagan [:djf]]

Note that this bug does not happen in a textarea that does autocapitalization.

Note also, that in a search field without autocaps, the shift key behaves like a shift lock key.  This may itself be a bug, but it is unrelated to the symbol keyboard.  If you're in that Bing search field and type shift, you'll stay caps locked until you type shift again.

All that happens when you go to the symbol layout and back is that we lose the highlight for shift mode.

So there are probably two bugs here

1) if the keyboard is not caps locked, it should revert to lowercase after each keystroke.

2) when returning from symbol layout, the keyboard should correctly highlight the shift key if the keyboard is in caps lock.

Rudy: I'd be happy to fix this myself. The first part, at least, is a bug I created, I think.  But because John already asked you to look at it, I don't want to assign it to myself in case you are already working on it.  So if you don't want it, please just assign it to me.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi David,

Yes, right now I am working on the fix for this issue.
Thank you.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6109/files

Pointer to Github pull-request

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 676963 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6109/files


Address the issues mentioned in Comment 3.
1. reset UpperCase state after each keystroke
2. show correct highlight for Caps key after changing layout page


[Approval Request Comment]
User impact if declined: The caps is not correctly highlighted, which is an obvious UI issue and confusing.

Comment 7

[Alex Keybl [:akeybl]]

P3 bb+, given we believe this is a major usability issue.

Comment 8

[David Flanagan [:djf]]

Comment on attachment 676963 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6109/files

See the comments on github.  This patch isn't quite enough: it doesn't retain the caps lock state when you go to symbols and back to alphabetic.

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to David Flanagan [:djf] from comment #8)
> See the comments on github.  This patch isn't quite enough: it doesn't
> retain the caps lock state when you go to symbols and back to alphabetic.

I think this is a feature, not a bug.

Android preserves the caps lock state after switching keyboard layouts, but iOS does not. I think the iOS behavior is less surprising because switching keyboard layout clears all keyboard state.

Plus, I trust Apple's UX design more than Google's. ;)

Comment 10

[David Flanagan [:djf]]

Chris, 

Well the current patch retains the shift state, but not the shift lock state.  I think it should retain both; you think it should retain netiher. But we probably both agree that retaining one of the two is not right.

And as an argument for retaining the caps lock state, think about typing "B2G" :-)

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

To note, you can just hit the shift again and it will become lowercase again.

You guys are both right in that either they both should or they both shouldn't retain... right now it's just lopsided with retaining the caps lock but not showing on the key itself.  It's an annoying bug for sure.

Comment 12

[Chris Peterson [:cpeterson]]

(In reply to David Flanagan [:djf] from comment #10)
> Well the current patch retains the shift state, but not the shift lock
> state.  I think it should retain both; you think it should retain netiher.
> But we probably both agree that retaining one of the two is not right.

I agree we should retain both or clear both states. Note that Android's stock keyboard clears the shifted state, but retains the caps lock state! :\

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi all,

Thanks for the input.
The behavior in current patch to reset caps lock after layout switch was intended.

But I think you guys are right that we should retain or clear them both.

Loop :rafael, our UX for keyboard in to have a look in case he has a different opinion.

Thanks.

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6109/files

Pointer to Github pull-request

Comment 15

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 677330 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6109/files

pull request updated:

 1. It will retain both upper case & caps lock after layout page changes.
 2. I would prefer keeping resetUpperCase() because:
    a. It would make setUpperCase as simple as just setting values and checking to prevent redundant IMERender.draw().
    b. The IME could invoke resetUpperCase() without knowing the internal states, like caps lock and the current layout page.

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

https://github.com/mozilla-b2g/gaia/pull/6109 merged.

Comment 17

[Walter Chen[:ypwalter][:wachen]]

Verified 2012-11-05
gaia commit ID	16fda982b02d7279abd1c15b66af25e692d502f3
gecko commit ID	e070197f4c89

It is fixed

Comment 20

[Omega Feng [:Omega] [:馮於懋]]

See bug 983043 for the latest UX spec.
Basically,
1) Shift On should be Shift Off after going back from symbol panel.
2) Caps Lock On should retain On after going back from symbol panel.

Comment 21

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Omega, this is an old bug that has been verified.
If you find anything that we could modify/improve, could you please open another bug and specify the STR (step to reproduce) and the gap between the behavior and the spec?

Thank you.

--
I'll modify the bug status back to fixed.

Comment 22

[Omega Feng [:Omega] [:馮於懋]]

Sure, here is the new filed one: bug 1038027.