806784 - some python syntax in populate_virtualenv.py does not work in Python 2.5

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Ian Neal]

The syntax of the print statement at 
http://mxr.mozilla.org/comm-central/source/mozilla/build/virtualenv/populate_virtualenv.py#180
seems to cause problems in Python 2.5 (works fine on 2.7, not tested against 2.6)
180                     print('Error processing command. Ignoring', \
181                         'because optional. (%s)' % ':'.join(package),
182                         file=self.log_handle)

It replaced:
print >>log_handle, 'Error processing command. Ignoring', \
                    'because optional. (%s)' % ':'.join(package)

so I believe using something like:
print >>self.log_handle, 'Error processing command. Ignoring', \
                         'because optional. (%s)' % ':'.join(package)
would work

Comment 1

[Ian Neal]

Expanding this, as also getting the following on 2.5 for windows:
e:/builds/slave/comm-cen-trunk-w32-ntly/build/mozilla/build/virtualenv/populate_virtualenv.py:170: Warning: 'with' will become a reserved keyword in Python 2.6
  File "e:/builds/slave/comm-cen-trunk-w32-ntly/build/mozilla/build/virtualenv/populate_virtualenv.py", line 170
    with open(os.path.join(python_lib, package[0]), 'a') as f:
            ^
SyntaxError: invalid syntax
*** Fix above errors and then restart with               "make -f client.mk build"

Comment 2

[Mike Hommey [:glandium]]

Python 2.5 is not supported anymore.

Comment 3

[Ed Morley [:emorley]]

(See bug 800614).