806927 - PBM - Add menu controls

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: Menu mockup

Allow users to create new tabs and private tabs from the Android Menu. A mockup is attached. 

Strings:
"New tab"
"New private tab"

Icon assets will be posted here shortly.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch the two new menu items to the main menu.
I have added the images for "Synced tabs" and "close all tabs", along with the strings in this patch itself. (I couldn't go back and remove it and it got a bit tedious). This will be used in the tabs-menu (Bug 806933).
This patch has GB specific icons for those phones.

Comment 2

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11fcd37bfb7d

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Backed out for failures
https://hg.mozilla.org/integration/mozilla-inbound/rev/a58070f72659

Comment 4

[Sriram Ramasubramanian [:sriram]]

Pushed again: https://hg.mozilla.org/integration/mozilla-inbound/rev/341dfa820cd5
(This has the new images included)

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/341dfa820cd5

Comment 6

[Cristian Nicolae (:xti)]

New private tab and New tab entries were added in Firefox Menu. Closing bug as verified fixed on:

Firefox 20.0a1 (2012-12-03)
Device: Galaxy S2
OS: Android 4.0.3

Comment 7

[Aaron Train [:aaronmt]]

Confused by the summary of this bug; looks like 'Close All Tabs' has been added regardless of any dependencies on PBM.