806929 - PBM - add context menu controls

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: Context menu mockup

Allow users to create new private tabs from long pressing a link in web content. A mockup is attached. 

String:
"Open link in new private tab"

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (1/2): For webpage.

This adds (copy/pastes) "open in new private tab" option.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 682599 [details] [diff] [review]
Patch (1/2): For webpage.

That's a wrong patch.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (1/2): For webpage

This adds the "open in new private tab" for links in webpages.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (2/2): For awesomescreen

And some copy paste for awesomescreen.

Comment 5

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87d836ed8e2a
https://hg.mozilla.org/integration/mozilla-inbound/rev/90ef95622f5e

Comment 7

[(no longer active)]

This landed on inbound a week ago...  What happened after it?!

Comment 8

[Kartikaya Gupta (email:[e-mail])]

It was backed out by mfinkle:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6cb490697a27

Dunno if it re-landed after that.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Ugh. I forgot to link it here. Thanks Kats.

Sriram - Can you push this to Try and see what the test failures were about?

Comment 10

[Sriram Ramasubramanian [:sriram]]

Done.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8c8bebfed40
https://hg.mozilla.org/integration/mozilla-inbound/rev/239f4371a480

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d8c8bebfed40
https://hg.mozilla.org/mozilla-central/rev/239f4371a480

Comment 12

[Ioana Chiorean]

The option "Open Link in New Private Tab" is present on latest Nightly: 
Firefox 20.0a1 (2012-12-18)
Device: Galaxy Nexus
OS: Android 4.1.1

Marking bug as VERIFIED FIXED.

Comment 13

[Andreea Pod]

Test cases already added: 
https://moztrap.mozilla.org/manage/cases/_detail/22285/
https://moztrap.mozilla.org/manage/cases/_detail/22286/