806989 - [Lock Screen] Re Design

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Comment 1

[steve]

Here is the beta of the visuals for the new lock screen unlocking mechanism. More detailed animation specs will be added with tweaked graphics (mainly around the animation to give the best affordance possible).

https://www.dropbox.com/sh/lcx2qoemgysfnv0/pWylTwKy14#f:03%20lock_stage%20two.png

Comment 2

[steve]

Here is the beta of the visuals for the new lock screen unlocking mechanism. More detailed animation specs will be added with tweaked graphics (mainly around the animation to give the best affordance possible).

https://www.dropbox.com/sh/lcx2qoemgysfnv0/pWylTwKy14

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Steve,

We are still waiting for addition information (animation description, assets) to begin implementation.

Rex, Yuren, Rudy, Dominic, Steve Chung, and Alive,

Any or you available taking this item? The target of completion is Tuesday end-of-day Pacific Time.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I can take it.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #3)
> Any or you available taking this item? The target of completion is Tuesday
> end-of-day Pacific Time.

Sorry, Thursday EOD I meant. :-/

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi Steve and Josh,

did you have any result of discussion for Lockscreen design at Friday?

Comment 7

[Josh Carpenter [:jcarpenter]]

Hi Yuren, yes we did. Steve is going to email you an updated visual design treatment, and I'll also follow up by email re: modifying the existing treatment.

Comment 8

[Josh Carpenter [:jcarpenter]]

Should be blocking +. This is a must-change for v1. Triagers contact me for details.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Reassign to Yuren.

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: Pull request

Hi Tim, could you help me to review this pull request? thanks!

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 682374 [details]
Pull request

Thanks for your effort! Please fix the patch according to the comments and request for review again.

Comment 12

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 682374 [details]
Pull request

Fixed according to the comment, please review it again.
thank you, Tim :D

https://github.com/mozilla-b2g/gaia/pull/6453

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 682374 [details]
Pull request

r=me, looks good! Please update it and merge it.

Comment 14

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Merged part1.

Comment 15

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: pull request part 2

Tim, could you review this pull request, too?
this pull request mostly the same pull request part 1
https://github.com/mozilla-b2g/gaia/pull/6481

please reference spec (Answering call and Incoming call visual cue) and video
https://www.dropbox.com/sh/lj9e2r36nd6cbx6/G5q5MiLbzC
https://www.dropbox.com/s/s80uu78rknp0jk5/dailer-lockscreen-demo.mp4

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 682982 [details]
pull request part 2

Redirect review since I cannot verify UI remotely. The code looks correct though I think.

Comment 17

[David Flanagan [:djf]]

Please fix lockscreen.js:938 before closing this bug. It needs .bind(this) on the callback funciton and is currently reporting an error to the console.

Comment 18

[Tim Taubert [:ttaubert] (inactive)]

(In reply to David Flanagan [:djf] from comment #17)
> Please fix lockscreen.js:938 before closing this bug. It needs .bind(this)
> on the callback funciton and is currently reporting an error to the console.

Filed bug 813045 for this.

Comment 19

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi David, Tim Taubert,

I incorporated it in pull request part 2.
Thank you all!

Comment 20

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 682982 [details]
pull request part 2

r=me, UI looks good.

Comment 21

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Merged.