[Lock Screen] Re Design

RESOLVED FIXED in B2G C1 (to 19nov)

Status

defect
P1
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: padamczyk, Assigned: yurenju)

Tracking

({polish})

unspecified
B2G C1 (to 19nov)
All
Other
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+)

Details

(Whiteboard: visual design)

Attachments

(2 attachments)

No description provided.
Here is the beta of the visuals for the new lock screen unlocking mechanism. More detailed animation specs will be added with tweaked graphics (mainly around the animation to give the best affordance possible).

https://www.dropbox.com/sh/lcx2qoemgysfnv0/pWylTwKy14#f:03%20lock_stage%20two.png
Here is the beta of the visuals for the new lock screen unlocking mechanism. More detailed animation specs will be added with tweaked graphics (mainly around the animation to give the best affordance possible).

https://www.dropbox.com/sh/lcx2qoemgysfnv0/pWylTwKy14
Steve,

We are still waiting for addition information (animation description, assets) to begin implementation.

Rex, Yuren, Rudy, Dominic, Steve Chung, and Alive,

Any or you available taking this item? The target of completion is Tuesday end-of-day Pacific Time.
Flags: needinfo?(padamczyk)
Flags: needinfo?(padamczyk) → needinfo?(authoritaire)
I can take it.
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #3)
> Any or you available taking this item? The target of completion is Tuesday
> end-of-day Pacific Time.

Sorry, Thursday EOD I meant. :-/
Component: Gaia → Gaia::System
Hi Steve and Josh,

did you have any result of discussion for Lockscreen design at Friday?
Hi Yuren, yes we did. Steve is going to email you an updated visual design treatment, and I'll also follow up by email re: modifying the existing treatment.
Should be blocking +. This is a must-change for v1. Triagers contact me for details.
blocking-basecamp: --- → ?
Keywords: polish
blocking-basecamp: ? → +
Priority: -- → P1
Target Milestone: --- → B2G C1 (to 19nov)
Reassign to Yuren.
Assignee: authoritaire → yurenju
Flags: needinfo?(authoritaire)
Posted file Pull request
Hi Tim, could you help me to review this pull request? thanks!
Attachment #682374 - Flags: review?(timdream+bugs)
Comment on attachment 682374 [details]
Pull request

Thanks for your effort! Please fix the patch according to the comments and request for review again.
Attachment #682374 - Flags: review?(timdream+bugs)
Comment on attachment 682374 [details]
Pull request

Fixed according to the comment, please review it again.
thank you, Tim :D

https://github.com/mozilla-b2g/gaia/pull/6453
Attachment #682374 - Flags: review?(timdream+bugs)
Comment on attachment 682374 [details]
Pull request

r=me, looks good! Please update it and merge it.
Attachment #682374 - Flags: review?(timdream+bugs) → review+
Merged part1.
Posted file pull request part 2
Tim, could you review this pull request, too?
this pull request mostly the same pull request part 1
https://github.com/mozilla-b2g/gaia/pull/6481

please reference spec (Answering call and Incoming call visual cue) and video
https://www.dropbox.com/sh/lj9e2r36nd6cbx6/G5q5MiLbzC
https://www.dropbox.com/s/s80uu78rknp0jk5/dailer-lockscreen-demo.mp4
Attachment #682982 - Flags: review?(timdream+bugs)
Comment on attachment 682982 [details]
pull request part 2

Redirect review since I cannot verify UI remotely. The code looks correct though I think.
Attachment #682982 - Flags: review?(timdream+bugs) → review?(alive)
Please fix lockscreen.js:938 before closing this bug. It needs .bind(this) on the callback funciton and is currently reporting an error to the console.
(In reply to David Flanagan [:djf] from comment #17)
> Please fix lockscreen.js:938 before closing this bug. It needs .bind(this)
> on the callback funciton and is currently reporting an error to the console.

Filed bug 813045 for this.
Hi David, Tim Taubert,

I incorporated it in pull request part 2.
Thank you all!
Comment on attachment 682982 [details]
pull request part 2

r=me, UI looks good.
Attachment #682982 - Flags: review?(alive) → review+
Merged.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.