TypeError: this.iconContainer is undefined in app://system.gaiamobile.org/js/lockscreen.js

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Fallout from bug 806989.
(Assignee)

Comment 1

5 years ago
Created attachment 683071 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6493

Pointer to Github pull-request
(Assignee)

Updated

5 years ago
Attachment #683071 - Flags: review?(yurenju)
(Assignee)

Updated

5 years ago
Assignee: nobody → ttaubert
(Assignee)

Updated

5 years ago
Attachment #683071 - Flags: review?(dflanagan)
Comment on attachment 683071 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6493

Thanks for fixing this.
Attachment #683071 - Flags: review?(dflanagan) → review+
(Assignee)

Comment 3

5 years ago
Comment on attachment 683071 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6493

Tiny and small fix.
Attachment #683071 - Flags: review?(yurenju) → approval-gaia-master?(21)
Tim,

The reason I just noted this on the bug that caused it was that that bug wasn't closed yet and still had blocking+, I think, so I was hoping it would be easier for Yuren to land it as part of the existing bug...
(Assignee)

Comment 5

5 years ago
Yeah, that makes sense. I had filed and fixed the bug before your comment, otherwise I probably would have waited for Yuren :)

Yuren, please feel free to incorporate the fix in your branch if you get to land that first!
Hi Tim, Thanks for fixing it! I incorporated it in pull request of Bug 806989 and it will be fixed when Bug 806989 closed.

Thank you all!
Pull request merged.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment #683071 - Flags: approval-gaia-master?(21)
You need to log in before you can comment on or make changes to this bug.