813045 - TypeError: this.iconContainer is undefined in app://system.gaiamobile.org/js/lockscreen.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Fallout from bug 806989.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6493

Pointer to Github pull-request

Comment 2

[David Flanagan [:djf]]

Comment on attachment 683071 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6493

Thanks for fixing this.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 683071 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6493

Tiny and small fix.

Comment 4

[David Flanagan [:djf]]

Tim,

The reason I just noted this on the bug that caused it was that that bug wasn't closed yet and still had blocking+, I think, so I was hoping it would be easier for Yuren to land it as part of the existing bug...

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Yeah, that makes sense. I had filed and fixed the bug before your comment, otherwise I probably would have waited for Yuren :)

Yuren, please feel free to incorporate the fix in your branch if you get to land that first!

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi Tim, Thanks for fixing it! I incorporated it in pull request of Bug 806989 and it will be fixed when Bug 806989 closed.

Thank you all!

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Pull request merged.