807171 - Implement AudioParam.cancelScheduledValues

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 676849 [details] [diff] [review]
Patch (v1)

>+        mEvents.RemoveElementsAt(i, mEvents.Length() - i);

  mEvents.TruncateLength(i);

r=me

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5fc85295afde

Comment 4

[Boris Zbarsky [:bzbarsky]]

One other thought.... would it make sense to binary search instead of linear search here?

Comment 5

[(no longer active)]

(In reply to comment #4)
> One other thought.... would it make sense to binary search instead of linear
> search here?

Maybe.  I don't yet know how many events will be typically set on an AudioParam, so depending on the real world use case that may not be worth it.  I have a comment in AudioEventTimeline.h which says how mEvents can be optimized in the future if we need to.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5fc85295afde

Comment 7

[(no longer active)]

Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.