Closed Bug 807215 Opened 13 years ago Closed 13 years ago

Intermittent browser_social_isVisible.js | an unexpected uncaught JS exception reported through window.onerror - TypeError: sbrowser.docShell is null at chrome://browser/content/browser.js:4853

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: philor, Unassigned)

References

Details

(Keywords: intermittent-failure)

https://tbpl.mozilla.org/php/getParsedLog.php?id=16600644&tree=Firefox Rev3 WINNT 5.1 mozilla-central pgo test mochitest-browser-chrome on 2012-10-30 15:24:44 PDT for push a5ab93cf9fea slave: talos-r3-xp-091 TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_social_isVisible.js | social URL https://example.com/browser/browser/base/content/test/moz.png should not be in global history (Many people find it a good thing to stop running here.) INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/browser_social_isVisible.js | finished in 91ms TEST-INFO | checking window state TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_social_isVisible.js | an unexpected uncaught JS exception reported through window.onerror - TypeError: sbrowser.docShell is null at chrome://browser/content/browser.js:4853 Stack trace: JS frame :: chrome://mochikit/content/tests/SimpleTest/SimpleTest.js :: simpletestOnerror :: line 983 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Version: 18 Branch → Trunk
The problem is: * browser_social_isVisible.js finishes its test after just having reopened the sidebar. SocialSidebar_updateSidebar opens it by setting the src= attribute and adding a load listener to actually show the sidebar once content is available. * Test cleanup forces social disabled. updateSidebar called again to close it, and as social is disabled forces an immediate unload - which adjust just adjusts the src= attribute back again. * load listener from step 1 fires (possibly from the new about:blank in the browser?). It's now trying to show the sidebar but it's been unloaded, so no docshell, hence error. Bug 807225 will be the same basic bug but when the sidebar hasn't been force unloaded - eg: * sidebar opened, load listener added. * sidebar closed while social still enabled - so timer started to unload. * load handler from first step fires - sidebar made visible when it should be hidden. Easiest is probably just for the load listener to check it should actually be visible by the time it fires.
Mark, are you working on this (given comment 3) or should I ask around? :-)
Flags: needinfo?(mhammond)
Blocks: 807225
I think this and bug 807225 should be fixed by bug 808243
Flags: needinfo?(mhammond)
(In reply to Mark Hammond (:markh) from comment #10) > I think this and bug 807225 should be fixed by bug 808243 Great, thanks! :-)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [orange]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.