807422 - Panels should open towards the center of the browser window

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Stephen Horlander [:shorlander]]

Attachment: Screenshot

Using Facebook in Nightly and Beta the panels are opening towards the outside of the browser window. They should be opening towards the center of the browser window like our other panels.

Attaching a screenshot. Sadly no one wants to be friends with me.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The panel used for toolbar button dropdowns is social-notification-panel:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#265

Do we need a position attribute on it? We open it here:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-social.js#925

Popup positioning still confuses me - MDN suggests that the "bottomcenter topleft" we pass there is not a valid value for that argument. All of the social popups in browser.xul and openPopup calls in browser-social should probably be reviewed by someone who knows how they work!

Comment 2

[Neil Deakin]

It sounds like you want 'bottomcenter topright' which means 'place the topright corner of the popup at the bottom center of the anchor button'.

Can the button be customized and placed elsewhere? You might want topleft for the situation where the button has moved to the left side of the toolbar.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

It sounds like it would be nice if there was a position option that means something like "whereever causes the least amount of the popup to be outside the application borders"

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 679926 [details] [diff] [review]
Patch

When we support moving the buttons around the toolbar let's remember to figure out a way to adaptively choose these values

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7fa101f3e81

(In reply to :Felipe Gomes from comment #5)
> Comment on attachment 679926 [details] [diff] [review]
> Patch
> 
> When we support moving the buttons around the toolbar let's remember to
> figure out a way to adaptively choose these values

Yep, filed bug 811112 for this.

Comment 7

[Dão Gottwald [:dao]]

Does this magically work for RTL?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Dão Gottwald [:dao] from comment #7)
> Does this magically work for RTL?

Yes it does. See the values here, http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsMenuPopupFrame.h#73 and how they are flipped in RTL mode here, http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsMenuPopupFrame.cpp#864

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c7fa101f3e81