807453 - [Clock] Alarm does not keep playing

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[[e-mail] [:onecyrenus]]

Gaia: 2012-10-30 ace1425c34...

Basically the Alarm needs to keep repeatedly playing the audio, until snooze or disable. 

right now it will play the audio file and stop.  This is a usability issue, because alarms generally need to keep playing until you tell them to stop.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

FYI, there was some additional changes that were made today : 
https://github.com/mozilla-b2g/gaia/pull/6115#issuecomment-9952466

I don't think this would affect the outcome, though.

Comment 2

[David Scravaglieri [:scravag]]

If it is too complicated please loop with UX to find something suitable

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Ian, this is now your bug.

Comment 4

[[e-mail], [e-mail]]

Let's discuss the solution at Bug 809087 - [Clock] Need to define the alarm's behaviors: how long does it ring and vibrate?

Comment 5

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6458

Pointer to Github pull-request

Comment 6

[[e-mail], [e-mail]]

Comment on attachment 682412 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6458

1. Let alarm goes off and keep the screen on continuously for 15 mins.
2. Fix to show the alarm time on the ringing page.(Bug 804702)

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 682412 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6458

r=me with some logic revised.

It looks like, as always, the bug filed doesn't match the fixes needed for Clock app. After this patch landed, would you please update the description and title of bug 804702 and bug 809087 on what needs to be done for the two bugs? Thanks.

Comment 8

[[e-mail], [e-mail]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #7)
> Comment on attachment 682412 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6458
> 
> r=me with some logic revised.
According Tim's comment, I have revised the patch with non-blocking section.
Since the pr is merged, we can close the issue now.
> 
> It looks like, as always, the bug filed doesn't match the fixes needed for
> Clock app. After this patch landed, would you please update the description
> and title of bug 804702 and bug 809087 on what needs to be done for the two
> bugs? Thanks.
Thank you for your reminder.
I'll refine the title for the above bugs.

Comment 9

[:CSchmoeckel]

Verified that the Clock Alarm now continues to sound minutes after it starts to go off. 
Verified on Build 20121231070201 on 12/31/12.

Comment 10

[:CSchmoeckel]

VERIFIED that the Clock Alarm now continues to sound minutes after it starts to go off. 
Verified on Build 20121231070201 on 12/31/12.