Remove nsIProfileChangeStatus, nsIProfile, and remnants of pre-Firefox profile handling

RESOLVED FIXED in mozilla20

Status

()

RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: benjamin, Assigned: benjamin)

Tracking

({addon-compat, dev-doc-complete})

unspecified
mozilla20
addon-compat, dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
nsIProfileChangeStatus, nsIProfile, and various notifications are no longer supported and should be removed. This was prompted by PSM trying yet again to veto profile shutdown (which hasn't been supported since mid-2004).
(Assignee)

Comment 1

6 years ago
Created attachment 677521 [details] [diff] [review]
PSM - remove profile change veto/restore bits, rev. 1
Attachment #677521 - Flags: review?(bsmith)
(Assignee)

Comment 2

6 years ago
Created attachment 677522 [details] [diff] [review]
Main part: remove nsIProfileChangeStatus, nsIProfile, move some docs, rev. 1
Attachment #677522 - Flags: review?(mh+mozilla)

Comment 3

6 years ago
Try run for aa4f0d8a0ab8 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=aa4f0d8a0ab8
Results (out of 2 total builds):
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bsmedberg@mozilla.com-aa4f0d8a0ab8

Comment 4

6 years ago
Try run for 96c08acb0fd3 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=96c08acb0fd3
Results (out of 27 total builds):
    success: 25
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/bsmedberg@mozilla.com-96c08acb0fd3
Comment on attachment 677522 [details] [diff] [review]
Main part: remove nsIProfileChangeStatus, nsIProfile, move some docs, rev. 1

Review of attachment 677522 [details] [diff] [review]:
-----------------------------------------------------------------

::: profile/public/nsIProfileChangeStatus.idl
@@ +40,1 @@
>      

While here, can you cleanup the spurious whitespaces?

@@ +58,4 @@
>  
> +NOTE: Long ago there was be a "shutdown-cleanse" version of shutdown which was
> +intended to clear profile data. This is no longer sent and observer code should
> +remove support for it.

Maybe file a bug for that cleanup? That could be an easy first bug for new contributors.
Attachment #677522 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

6 years ago
Blocks: 362649
(Assignee)

Updated

6 years ago
Blocks: 715137
Comment on attachment 677521 [details] [diff] [review]
PSM - remove profile change veto/restore bits, rev. 1

Review of attachment 677521 [details] [diff] [review]:
-----------------------------------------------------------------

It is still important to fix the problem that is causing NSS shutdown to fail. There is already at least one bug tracking that issue.

::: security/manager/ssl/src/nsNSSComponent.cpp
@@ +2553,5 @@
>      
>    StopCRLUpdateTimer();
>  
>    if (needsCleanup) {
> +    ShutdownNSS();

Change ShutdownNSS return type from nsresult to void since we don't check the return value any more.
Attachment #677521 - Flags: review?(bsmith) → review+
(In reply to Mike Hommey [:glandium] from comment #5)
> @@ +58,4 @@
> >  
> > +NOTE: Long ago there was be a "shutdown-cleanse" version of shutdown which was
> > +intended to clear profile data. This is no longer sent and observer code should
> > +remove support for it.
> 
> Maybe file a bug for that cleanup? That could be an easy first bug for new
> contributors.

I filed bug 820613.

Comment 8

6 years ago
Backed out for "nsNSSComponent.cpp:1879:3: error: void function 'ShutdownNSS' should not return a value [-Wreturn-type]" etc:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=4ebd50016f35

https://hg.mozilla.org/integration/mozilla-inbound/rev/85d46df9a125
(Assignee)

Comment 9

6 years ago
PSM: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b34780b29a6
main part: https://hg.mozilla.org/integration/mozilla-inbound/rev/1b416c9255ef

Jorge, this patch removes two "vestigial" interfaces which addons are probably not using:

* nsIProfile
* nsIProfileChangeStatus

But we should probably add these to the validator for FF20.
Keywords: addon-compat
Target Milestone: --- → mozilla20
Keywords: dev-doc-needed
Documentation has been updated:

* https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIProfile now reflects that this interface is obsolete, and the version in which it happened.

* https://developer.mozilla.org/en-US/Firefox/Releases/20#Changes_for_add-on_and_Mozilla_developers has been updated to include this change.
Keywords: dev-doc-needed → dev-doc-complete

Updated

4 years ago
Blocks: 605282

Updated

3 years ago
Depends on: 469214
You need to log in before you can comment on or make changes to this bug.