807757 - Remove nsIProfileChangeStatus, nsIProfile, and remnants of pre-Firefox profile handling

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Benjamin Smedberg]

nsIProfileChangeStatus, nsIProfile, and various notifications are no longer supported and should be removed. This was prompted by PSM trying yet again to veto profile shutdown (which hasn't been supported since mid-2004).

Comment 1

[Benjamin Smedberg]

Attachment: PSM - remove profile change veto/restore bits, rev. 1

Comment 2

[Benjamin Smedberg]

Attachment: Main part: remove nsIProfileChangeStatus, nsIProfile, move some docs, rev. 1

Comment 3

[Mozilla RelEng Bot]

Try run for aa4f0d8a0ab8 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=aa4f0d8a0ab8
Results (out of 2 total builds):
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-aa4f0d8a0ab8

Comment 4

[Mozilla RelEng Bot]

Try run for 96c08acb0fd3 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=96c08acb0fd3
Results (out of 27 total builds):
    success: 25
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-96c08acb0fd3

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 677522 [details] [diff] [review]
Main part: remove nsIProfileChangeStatus, nsIProfile, move some docs, rev. 1

Review of attachment 677522 [details] [diff] [review]:
-----------------------------------------------------------------

::: profile/public/nsIProfileChangeStatus.idl
@@ +40,1 @@
>      

While here, can you cleanup the spurious whitespaces?

@@ +58,4 @@
>  
> +NOTE: Long ago there was be a "shutdown-cleanse" version of shutdown which was
> +intended to clear profile data. This is no longer sent and observer code should
> +remove support for it.

Maybe file a bug for that cleanup? That could be an easy first bug for new contributors.

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 677521 [details] [diff] [review]
PSM - remove profile change veto/restore bits, rev. 1

Review of attachment 677521 [details] [diff] [review]:
-----------------------------------------------------------------

It is still important to fix the problem that is causing NSS shutdown to fail. There is already at least one bug tracking that issue.

::: security/manager/ssl/src/nsNSSComponent.cpp
@@ +2553,5 @@
>      
>    StopCRLUpdateTimer();
>  
>    if (needsCleanup) {
> +    ShutdownNSS();

Change ShutdownNSS return type from nsresult to void since we don't check the return value any more.

Comment 7

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Mike Hommey [:glandium] from comment #5)
> @@ +58,4 @@
> >  
> > +NOTE: Long ago there was be a "shutdown-cleanse" version of shutdown which was
> > +intended to clear profile data. This is no longer sent and observer code should
> > +remove support for it.
> 
> Maybe file a bug for that cleanup? That could be an easy first bug for new
> contributors.

I filed bug 820613.

Comment 8

[Ed Morley [:emorley]]

Backed out for "nsNSSComponent.cpp:1879:3: error: void function 'ShutdownNSS' should not return a value [-Wreturn-type]" etc:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=4ebd50016f35

https://hg.mozilla.org/integration/mozilla-inbound/rev/85d46df9a125

Comment 9

[Benjamin Smedberg]

PSM: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b34780b29a6
main part: https://hg.mozilla.org/integration/mozilla-inbound/rev/1b416c9255ef

Jorge, this patch removes two "vestigial" interfaces which addons are probably not using:

* nsIProfile
* nsIProfileChangeStatus

But we should probably add these to the validator for FF20.

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/6b34780b29a6
https://hg.mozilla.org/mozilla-central/rev/1b416c9255ef

Comment 11

[Eric Shepherd [:sheppy]]

Documentation has been updated:

* https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIProfile now reflects that this interface is obsolete, and the version in which it happened.

* https://developer.mozilla.org/en-US/Firefox/Releases/20#Changes_for_add-on_and_Mozilla_developers has been updated to include this change.