Closed Bug 808289 Opened 13 years ago Closed 13 years ago

Win32/Linux Nightly localised builds use en-US strings for interface

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Version:
19 Branch
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(firefox18 unaffected, firefox19+ verified)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox18 --- unaffected
firefox19 + verified

People

(Reporter: unghost, Assigned: Pike)

References

Details

(Keywords: regression)

Attachments

(1 file)

use the locale-specific dir instead of the l10n-base as base for this locale
1020 bytes, patch
ted
: review+
Details | Diff | Splinter Review
STR: 1) Download and run http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/firefox-19.0a1.ru.linux-i686.tar.bz2 Expected results: Interface in Russian Actual results: Interface in English
Win32 build - http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/firefox-19.0a1.ru.win32.installer.exe - localization is mixed: installer is in Russian, browser interface is in English
Summary: Linux Nightly localised builds contain en-US strings → Win32/Linux Nightly localised builds use en-US strings for interface
Probably caused by Bug 797745
Ouch, yes, my bad. Got a fix in hand.
Assignee: nobody → l10n
Component: Release Engineering → Build Config
Depends on: 797745
Product: mozilla.org → Firefox
Version: other → Trunk
I've landed this as https://hg.mozilla.org/mozilla-central/rev/8709528b6e1f as bustage fix, requesting post-landing review from ted. The problem was that I was passing the l10n-base as base for the localization, instead of l10n-base/locale. I didn't recognize this earlier because it's only affecting files that don't appear in the merged dir, and my german browser has a bit of merged content in the main UI.
Attachment #678019 - Flags: review?(ted)
tracking-firefox19: --- → ?
Keywords: regression
Version: Trunk → 19 Branch
Blocks: 808328
This fixed today's nightly for me. Leaving open 'til I get a review from Ted.
For our purposes, we'll mark this as fixed (although it makes sense to leave open for Ted's review).
status-firefox18: --- → unaffected
status-firefox19: --- → fixed
tracking-firefox19: ? → +
Comment on attachment 678019 [details] [diff] [review] use the locale-specific dir instead of the l10n-base as base for this locale Review of attachment 678019 [details] [diff] [review]: ----------------------------------------------------------------- Sorry I didn't get to this sooner, but this looks fine.
Attachment #678019 - Flags: review?(ted) → review+
Thanks, marking FIXED then.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified fixed FF 19b3 ru and nightly 21.0a1 (2013-01-29) ru.
Status: RESOLVED → VERIFIED
status-firefox19: fixed → verified
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: