808501 - Focusing chat bar focuses incorrect chat

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

STR:
* Open 2 chats.
* Focus the first chat you opened.
* Optional: move focus to URL bar or similar.
* Press Accel+Shift+C - the keyboard shortcut to focus the chatbar.

Actual:
* Focus is moved from the first opened chat to the second.

Expected:
* Focus remains in the previously focused first chat.

If you use the sidebar to click on a user and select a different chat, then this new chat always gets the new focus.  IOW, it isn't actually the "most recently opened" chat that always gets focus, it's the "most recently selected via the sidebar" chat which does.

FWIW, while I can see the second chat get focus in this case, I can't see where we actually set focus.  Is it possible the facebook content is managing to shift focus?

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Mark Hammond (:markh) from comment #0) 
> FWIW, while I can see the second chat get focus in this case, I can't see
> where we actually set focus.  Is it possible the facebook content is
> managing to shift focus?

When using the keyboard shortcut, the focus is set by http://hg.mozilla.org/mozilla-central/diff/cd2b8f31f59b/browser/base/content/browser-social.js. I do believe that the Facebook content is also calling element.focus() after onload.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

This patch returns focus to the selected chat when the keyboard shortcut is used.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v1.1

After talking on IRC, I updated this patch to not adjust focus if there aren't any chatboxes in the DOM. If there are, then selectedChat will be non-null.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 681740 [details] [diff] [review]
Patch v1.1

Review of attachment 681740 [details] [diff] [review]:
-----------------------------------------------------------------

untested by me, but looks good.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9c9d1ff7a15

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e9c9d1ff7a15