808519 - BaselineCompiler: Refactor frame iteration to support baseline JIT frames

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Main issue is that the baseline compiler won't use snapshots, so we can't use InlineFrameIterator.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1: Rename IonFrame_JS to IonFrame_OptimizedJS

Patch for inbound to rename IonFrame_JS to IonFrame_OptimizedJS (better name welcome). The baseline JIT can use IonFrame_BaselineJS. I hope we can use the same frame prefix so the patch doesn't rename IonJSFrameLayout.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 678303 [details] [diff] [review]
Part 1: Rename IonFrame_JS to IonFrame_OptimizedJS

Review of attachment 678303 [details] [diff] [review]:
-----------------------------------------------------------------

OptimizedJS seems fine to me. We could drop the IonFrame_ prefix someday too.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 2: Rename MaybeScriptFromCalleeToken and call it in GetTopIonJSScript

Renames MaybeScriptFromCalleeToken to ScriptFromCalleeToken (result is always non-NULL) and calls it from GetTopIonJSScript.

Comment 4

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1cc2de645efd
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a13c51926cd

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1cc2de645efd
https://hg.mozilla.org/mozilla-central/rev/9a13c51926cd