BaselineCompiler: Refactor frame iteration to support baseline JIT frames

RESOLVED FIXED in mozilla19

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Main issue is that the baseline compiler won't use snapshots, so we can't use InlineFrameIterator.
(Assignee)

Comment 1

6 years ago
Created attachment 678303 [details] [diff] [review]
Part 1: Rename IonFrame_JS to IonFrame_OptimizedJS

Patch for inbound to rename IonFrame_JS to IonFrame_OptimizedJS (better name welcome). The baseline JIT can use IonFrame_BaselineJS. I hope we can use the same frame prefix so the patch doesn't rename IonJSFrameLayout.
Attachment #678303 - Flags: review?(dvander)
Comment on attachment 678303 [details] [diff] [review]
Part 1: Rename IonFrame_JS to IonFrame_OptimizedJS

Review of attachment 678303 [details] [diff] [review]:
-----------------------------------------------------------------

OptimizedJS seems fine to me. We could drop the IonFrame_ prefix someday too.
Attachment #678303 - Flags: review?(dvander) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 678312 [details] [diff] [review]
Part 2: Rename MaybeScriptFromCalleeToken and call it in GetTopIonJSScript

Renames MaybeScriptFromCalleeToken to ScriptFromCalleeToken (result is always non-NULL) and calls it from GetTopIonJSScript.
Attachment #678312 - Flags: review?(dvander)
(Assignee)

Updated

6 years ago
Attachment #678312 - Flags: review?(dvander)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/1cc2de645efd
https://hg.mozilla.org/mozilla-central/rev/9a13c51926cd
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.