BaselineCompiler: Refactor frame iteration to support baseline JIT frames

RESOLVED FIXED in mozilla19

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla19
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Main issue is that the baseline compiler won't use snapshots, so we can't use InlineFrameIterator.
Patch for inbound to rename IonFrame_JS to IonFrame_OptimizedJS (better name welcome). The baseline JIT can use IonFrame_BaselineJS. I hope we can use the same frame prefix so the patch doesn't rename IonJSFrameLayout.
Attachment #678303 - Flags: review?(dvander)
Comment on attachment 678303 [details] [diff] [review]
Part 1: Rename IonFrame_JS to IonFrame_OptimizedJS

Review of attachment 678303 [details] [diff] [review]:
-----------------------------------------------------------------

OptimizedJS seems fine to me. We could drop the IonFrame_ prefix someday too.
Attachment #678303 - Flags: review?(dvander) → review+
Renames MaybeScriptFromCalleeToken to ScriptFromCalleeToken (result is always non-NULL) and calls it from GetTopIonJSScript.
Attachment #678312 - Flags: review?(dvander)
Attachment #678312 - Flags: review?(dvander)
https://hg.mozilla.org/mozilla-central/rev/1cc2de645efd
https://hg.mozilla.org/mozilla-central/rev/9a13c51926cd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.