Closed Bug 808519 Opened 8 years ago Closed 8 years ago

BaselineCompiler: Refactor frame iteration to support baseline JIT frames

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(2 files)

Main issue is that the baseline compiler won't use snapshots, so we can't use InlineFrameIterator.
Patch for inbound to rename IonFrame_JS to IonFrame_OptimizedJS (better name welcome). The baseline JIT can use IonFrame_BaselineJS. I hope we can use the same frame prefix so the patch doesn't rename IonJSFrameLayout.
Attachment #678303 - Flags: review?(dvander)
Comment on attachment 678303 [details] [diff] [review]
Part 1: Rename IonFrame_JS to IonFrame_OptimizedJS

Review of attachment 678303 [details] [diff] [review]:
-----------------------------------------------------------------

OptimizedJS seems fine to me. We could drop the IonFrame_ prefix someday too.
Attachment #678303 - Flags: review?(dvander) → review+
Renames MaybeScriptFromCalleeToken to ScriptFromCalleeToken (result is always non-NULL) and calls it from GetTopIonJSScript.
Attachment #678312 - Flags: review?(dvander)
Attachment #678312 - Flags: review?(dvander)
https://hg.mozilla.org/mozilla-central/rev/1cc2de645efd
https://hg.mozilla.org/mozilla-central/rev/9a13c51926cd
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.