Closed Bug 808525 Opened 13 years ago Closed 11 years ago

OSX ASan builds broken on mozilla-aurora due to WebRTC defines

Categories

(Core :: WebRTC, defect, P1)

Product:
Core
Component:
WebRTC
Platform:
x86_64
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Blocking Flags:
backlog webrtc/webaudio+

People

(Reporter: decoder, Unassigned)

References

Details

(Keywords: sec-want, Whiteboard: [asan-build-blocker])

Since a while, the mozilla-aurora ASan builds are broken on OSX, because media/webrtc/signaling/signaling.gyp is setting _FORTIFY_SOURCE=2 although it is internally forced to be off by ASan (I guess they are incompatible). That causes a macro redefinition warning which is converted to an error due to -Werror in use. This doesn't break on mozilla-central because bug 800401 removed all -Werror from that file. One solution would be to uplift that patch to aurora, another would be to not set _FORTIFY_SOURCE=2 in ASan builds. I don't know what solution is preferred. The build log is at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/choller@mozilla.com-47c74b041d57/try-macosx64-debug/try-macosx64-debug-bm33-try1-build2196.txt.gz
Priority: -- → P1
Whiteboard: [asan-build-blocker] → [asan-build-blocker][WebRTC][blocking-webrtc+]
Not a blocker for preffing on. ASAN people should decide what they want to do, and ask for uplift on that bug if wished.
Depends on: 800401
Whiteboard: [asan-build-blocker][WebRTC][blocking-webrtc+] → [asan-build-blocker][WebRTC][blocking-webrtc-]
backlog: --- → webRTC+
Rank: 15
Whiteboard: [asan-build-blocker][WebRTC][blocking-webrtc-] → [asan-build-blocker]
Fixed long ago
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.